Markers should be time based and not sample based

RESOLVED FIXED in mozilla30

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vikstrous, Assigned: vikstrous)

Tracking

unspecified
mozilla30
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Right now markers are associated with samples. They should be associated with a time instead so that we can have markers between samples without losing their specific time information. This will also allow us to put comments between samples.
(Assignee)

Updated

5 years ago
Assignee: nobody → vstanchev
(Assignee)

Comment 1

5 years ago
Created attachment 8375128 [details] [diff] [review]
marker_time
Attachment #8375128 - Flags: review?(bgirard)
Comment on attachment 8375128 [details] [diff] [review]
marker_time

Review of attachment 8375128 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I think we should be using float. I made the mistake of using float elsewhere. We should switch to float instead of double.

::: tools/profiler/PseudoStack.h
@@ +134,3 @@
>  private:
>    char* mMarkerName;
> +  double mTime;

Do you mind packing this structure better? double first, then pointers then int.
Attachment #8375128 - Flags: review?(bgirard) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 8375146 [details] [diff] [review]
marker_time
Attachment #8375128 - Attachment is obsolete: true
I mean warnings as errors.
(Assignee)

Updated

5 years ago
Flags: needinfo?(bgirard)
https://hg.mozilla.org/mozilla-central/rev/93c87caa7855
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.