Closed Bug 970494 Opened 6 years ago Closed 6 years ago

Markers should be time based and not sample based

Categories

(Core :: Gecko Profiler, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: vikstrous, Assigned: vikstrous)

Details

Attachments

(1 file, 2 obsolete files)

Right now markers are associated with samples. They should be associated with a time instead so that we can have markers between samples without losing their specific time information. This will also allow us to put comments between samples.
Assignee: nobody → vstanchev
Attached patch marker_time (obsolete) — Splinter Review
Attachment #8375128 - Flags: review?(bgirard)
Comment on attachment 8375128 [details] [diff] [review]
marker_time

Review of attachment 8375128 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I think we should be using float. I made the mistake of using float elsewhere. We should switch to float instead of double.

::: tools/profiler/PseudoStack.h
@@ +134,3 @@
>  private:
>    char* mMarkerName;
> +  double mTime;

Do you mind packing this structure better? double first, then pointers then int.
Attachment #8375128 - Flags: review?(bgirard) → review+
Attached patch marker_time (obsolete) — Splinter Review
Attachment #8375128 - Attachment is obsolete: true
I mean warnings as errors.
Flags: needinfo?(bgirard)
https://hg.mozilla.org/mozilla-central/rev/93c87caa7855
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.