970536 - 'attach' request packet error with Debugger tab

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Connect to the 1.2 or 1.3 Simulator in App Manager
2. Go to the Installed Apps page
3. Start and Debug your favorite app (it doesn't seem to matter which one), such as "Gallery"
4. Click on the Debugger tab in the toolbox
5. The stack trace below appears in the Browser Console

DebuggerPane.prototype.open threw an exception: Error: 'attach' request packet has no destination.
Stack: DebuggerClient.prototype.request@resource://gre/modules/devtools/dbg-client.jsm:594
DebuggerClient.prototype.attachTracer@resource://gre/modules/devtools/dbg-client.jsm:554
DebuggerController._startTracingTab@chrome://browser/content/devtools/debugger-controller.js:406
DebuggerController.connect@chrome://browser/content/devtools/debugger-controller.js:240
DebuggerPanel.prototype.open/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/jryans/projects/mozilla/gecko/browser/devtools//debugger/panel.js:53
resolve@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
resolve@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
resolve@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
then@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:43
then@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:153
resolve@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:185
resolve@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
then@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:43
resolve@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:185
DebuggerView._onEditorLoad/<@chrome://browser/content/devtools/debugger-view.js:260
resolve@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
then@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:43
then@resource://gre/modules/XPIProvider.jsm -> file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/[e-mail]/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:153
DebuggerView._onEditorLoad@chrome://browser/content/devtools/debugger-view.js:258
DebuggerView._initializeEditor/<@chrome://browser/content/devtools/debugger-view.js:236
Handler.prototype.process@resource://gre/modules/Promise.jsm:767
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:531
Line: 594, column: 6 DevToolsUtils.js:56
A promise chain failed to handle a rejection.

Date: Mon Feb 10 2014 15:01:50 GMT-0600 (CST)
Full Message: Unix error 2 during operation open (No such file or directory)
Full Stack: JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleException :: line 301
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleException :: line 301
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleException :: line 301
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
JS frame :: resource://gre/modules/Promise.jsm :: Handler.prototype.process :: line 770
JS frame :: resource://gre/modules/Promise.jsm :: this.PromiseWalker.walkerLoop :: line 531
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: The debugger shouldn't try to connect to the tracer actor if it is not present or if tracing is disabled

Oops.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: The debugger shouldn't try to connect to the tracer actor if it is not present or if tracing is disabled v2

Now with a test.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8374066 [details] [diff] [review]
The debugger shouldn't try to connect to the tracer actor if it is not present or if tracing is disabled v2

Review of attachment 8374066 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/test/browser_dbg_tracing-06.js
@@ +18,5 @@
> +      gDebugger = gPanel.panelWin;
> +
> +      waitForSourceShown(gPanel, "code_tracing-01.js")
> +        .then(() => {
> +          ok(!gDebugger.DebuggerController.traceClient, "no traceClient was found");

"Should not have a trace client"

Reading only the string, I'd assume that we *want* a trace client!

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Modified test and landed:
https://hg.mozilla.org/integration/fx-team/rev/2b95fec2f1f5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for mochitest-bc orange.
https://hg.mozilla.org/integration/fx-team/rev/24c92e086d5a

https://tbpl.mozilla.org/php/getParsedLog.php?id=34550988&tree=Fx-Team

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Ugh, that's... surprising! The test passes locally in 4 different build configurations, so I can't see what could be wrong with it.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

I found a successful workaround for the test:
https://tbpl.mozilla.org/?tree=Try&rev=a7bedd2c554d
Relanded:
https://hg.mozilla.org/integration/fx-team/rev/0d98212a6c29

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0d98212a6c29