970569 - Fix crasher introduced by bug 928930

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Comment 1

[Eric Rescorla (:ekr)]

Attachment: Patch

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8373637 [details] [diff] [review]
Patch

Review of attachment 8373637 [details] [diff] [review]:
-----------------------------------------------------------------

Don't have quite enough context to say for sure whether this will fix the crash we were seeing, but things look better if only due to the conversion of transport_. A couple of very minor nits that I don't care that much about, but should at least point out.

::: media/mtransport/nricectx.cpp
@@ +188,5 @@
>  
>  
>  
>  nsresult NrIceStunServer::ToNicerStunStruct(nr_ice_stun_server *server,
> +                                            const std::string& transport) const {

Placement of '&' is inconsistent.

::: media/mtransport/nricectx.h
@@ +102,5 @@
>      return server.forget();
>    }
>  
>    nsresult ToNicerStunStruct(nr_ice_stun_server *server,
> +                             const std::string& transport =

Placement of '&' inconsistent.

Comment 3

[Eric Rescorla (:ekr)]

Attachment: Patch

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8373661 [details] [diff] [review]
Patch

Review of attachment 8373661 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de1c051de2d2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de1c051de2d2