a little cleanup in 3d transform code in nsFrame.cpp

RESOLVED FIXED in mozilla30

Status

()

Core
Layout
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla30
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
I was poking around to understand some of the 3-D transform code in nsFrame.cpp related to overflow calculation, and noticed a few things that could be cleaned up:

 * unneeded null checks, since a style context's StyleDisplay() method never returns null

 * and some indentation and bracing
(Assignee)

Comment 1

4 years ago
Created attachment 8373715 [details] [diff] [review]
patch 1:  Remove some null-checks and simplify control flow in nsIFrame::HasPerspective and nsIFrame::ChildrenHavePerspective.
Attachment #8373715 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

4 years ago
Created attachment 8373716 [details] [diff] [review]
patch 2:  Fix indentation and bracing in nsIFrame::Preserves3DChildren.
Attachment #8373716 - Flags: review?(matt.woodrow)
(Assignee)

Comment 3

4 years ago
Created attachment 8373717 [details] [diff] [review]
patch 3:  Rename (to match convention) and better share nsStyleDisplay* variable in nsIFrame::Preserves3DChildren.
Attachment #8373717 - Flags: review?(matt.woodrow)
Attachment #8373715 - Flags: review?(matt.woodrow) → review+
Attachment #8373716 - Flags: review?(matt.woodrow) → review+
Attachment #8373717 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/e9d0891f2bd6
https://hg.mozilla.org/mozilla-central/rev/a1231e092c8e
https://hg.mozilla.org/mozilla-central/rev/f8bcce65926d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.