Use mozSettings for Web Results deviceId parameter

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Right now we do some crazy stuff with datastore, but using mozSettings seems much more straightforward. Not sure why I didn't suggest this before.
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8400388 [details] [review]
Github pull request

In progress.
(Assignee)

Comment 2

4 years ago
Comment on attachment 8400388 [details] [review]
Github pull request

Amir, Ran - could one of you guys review this one? Thanks!
Attachment #8400388 - Flags: review?(ran)
Attachment #8400388 - Flags: review?(amirn)

Comment 3

4 years ago
Well, at least we found a Datastore API bug with our implementation :)
(https://bugzilla.mozilla.org/show_bug.cgi?id=986056#c8)

I will review.
Thanks Kevin.

Comment 4

4 years ago
adding reference to bug 957978 where deviceId sharing was implemented with Datastore API

Comment 5

4 years ago
looks good, added few small changes and a question on Github:
https://github.com/EverythingMe/gaia/commit/6f944a25ad401acaa004206e13788f284ee4e560
(Assignee)

Comment 6

4 years ago
Thanks Amir, that was really helpful. Issues have been addressed and the pull request is updated.

Updated

4 years ago
Attachment #8400388 - Flags: review?(amirn) → review+

Comment 8

4 years ago
Kevin, can please address Comment 7 and land (already r+)

Thanks.
(Assignee)

Comment 9

4 years ago
No, that's great :) I probably should've just taken the commit from your branch. Thanks for letting me know and the quick turnaround!
(Assignee)

Comment 10

4 years ago
Comment on attachment 8400388 [details] [review]
Github pull request

Going with r=amir, feel free to land any comments if you have any ran. Waiting on travis.
Attachment #8400388 - Flags: review?(ran)
(Assignee)

Comment 11

4 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/b86e36e616ae50a355f0b79bf7519bfa29da1582
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.