970697 - Mozillians page seems to wrap at a weird location

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Dave Hylands [:dhylands]]

Attachment: screenshot.png

I attached a screenshot which shows what I'm talking about.

If you drop a long from the right side of the yellow shaded header, that's where I would have expected things to wrap.

On my page, it's wrapping www.davehylands.com way earlier than that, with loads of white space on the right.

I'm not sure if the categories and stuff are right here. I just clicked ont he "File a bug" link.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

:wbowling, can you review when you have a moment?

Comment 2

[Wray Bowling [:wbowling]]

Well, this is technically by design. Let's say that the URL was one character longer and the text was set to wrap after the icon. Then you'd still have an orphaned 'm' and the line would break. If the desire is to make the URL show up on one line, then I say we put an ellipsis on it and not try to wrap it at all, but I have to wonder if anyone with a particularly long domain name will be upset.

Comment 3

[William Reynolds [:williamr]]

As an alternative, could we make the "profile-contact" section wider so that it's right boundary matches up with the position of the right side of the yellow status message?

The screenshot in comment 0 shows there is extra white space on the right side of the "profile-contact" section that is not being used but could be.

Comment 4

[Dave Hylands [:dhylands]]

(In reply to William Reynolds [:williamr] from comment #3)
> As an alternative, could we make the "profile-contact" section wider so that
> it's right boundary matches up with the position of the right side of the
> yellow status message?
> 
> The screenshot in comment 0 shows there is extra white space on the right
> side of the "profile-contact" section that is not being used but could be.

Yeah - that's more of what I was complaining about. I fully expect that it has to wrap somewhere. But it seems to be wrapping quite a bit earlier than it should.

Personally, I don't know why there's all that white space on either side of the yellow either (but that's a separate issue).

I can resize my window from half of my monitor wide to the full width of my monitor and all it does is add more white space on either side of the yellow bar, which seems totally wasteful to me.

Comment 5

[Giorgos Logiotatidis [:giorgos]]

I'd also experiment with removing the right sidebar and moving its contents to the main column. Currently the sidebar hold really valueable info, like email, and it's placed on the side and with smaller letters than less important info for the main column.

I like what linkedin does:
 * All info about the person is in the same column
 * Important info at the top, visually seperated from secondary info.

Comment 6

[Wray Bowling [:wbowling]]

Good ideas all around. I'll look in to this today.

Comment 7

[Wray Bowling [:wbowling]]

There's a pull request for this. https://github.com/mozilla/mozillians/pull/883

Comment 8

[Wray Bowling [:wbowling]]

I updated the pull request for this today.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/8d05a0efe19e0b16c08418dac90c5f0c520a409f
[fix bug 970697] Display websites in central column.

https://github.com/mozilla/mozillians/commit/4d82a63ea344055ed5c6a05ef0b01889de004efa
Merge pull request #902 from glogiotatidis/970697

[fix bug 970697] Display websites in central column.

Comment 10

[Matt Brandt [:mbrandt]]

QA verified on stage - the websites url has been relocated to the /u/<user_name>/ central column.