970727 - Move DEFFILE to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

I did not touch db/sqlite3/src/Makefile.in for now since the DEFFILE variable was used in the Makefile.in later on.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 8373782 [details] [diff] [review]
Patch (v1)

Review of attachment 8373782 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/public/ia2/moz.build
@@ +9,5 @@
>  FORCE_SHARED_LIB = True
>  
>  DEFINES['REGISTER_PROXY_DLL'] = True
> +
> +DEFFILE = SRCDIR + '/IA2Marshal.def'

I'd get rid of the SRCDIRs at the same time. They are supposedly useless.
(Note that does apply to RCFILE too)

Comment 2

[(no longer active)]

Comment on attachment 8373782 [details] [diff] [review]
Patch (v1)

(In reply to Mike Hommey [:glandium] from comment #1)
> Comment on attachment 8373782 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 8373782 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/public/ia2/moz.build
> @@ +9,5 @@
> >  FORCE_SHARED_LIB = True
> >  
> >  DEFINES['REGISTER_PROXY_DLL'] = True
> > +
> > +DEFFILE = SRCDIR + '/IA2Marshal.def'
> 
> I'd get rid of the SRCDIRs at the same time. They are supposedly useless.
> (Note that does apply to RCFILE too)

No, they're not.  The link.exe command seems to be run from the objdir, and not specifying the SRCDIRs like this will cause the link command to fail because it would not be able to find the .def file.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8373782 [details] [diff] [review]
Patch (v1)

Too bad the preprocessed .def.in files mean we can't just assume they're all in the srcdir and do the pre-pending in mozbuild.

Comment 4

[(no longer active)]

(In reply to Michael Shal [:mshal] from comment #3)
> Comment on attachment 8373782 [details] [diff] [review]
> Patch (v1)
> 
> Too bad the preprocessed .def.in files mean we can't just assume they're all
> in the srcdir and do the pre-pending in mozbuild.

I don't know how we usually handle preprocessed files in the moz.build world, but presumably if the build system is aware of the preprocessing outside of a makefile rule, then it can do this magic automatically.  This is material for a follow-up but though, I have no idea how to implement such magic.

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e93b626422f6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e93b626422f6