Open Bug 970770 Opened 8 years ago Updated 4 years ago

Remove nsHapticFeedback on non-Android build

Categories

(Core :: DOM: Device Interfaces, defect, P3)

x86
Windows 8.1
defect

Tracking

()

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

This interface was created by old Fennec, but...

- Windows ports has skeleton nsHapticFeedback, but this isn't used because XPCOM interface isn't registered.
- QT and GTK ports have same one, but it isn't built now.

So we can remove it from tree.  This is used for Fennec Android only.
Attached patch v1Splinter Review
Assignee: nobody → m_kato
Comment on attachment 8373840 [details] [diff] [review]
v1

Desktop version doesn't use this interface.  We should remove it except to android.

Also, unix directory becomes be used by Qt, so we should rename directory name from unix to qt.
Attachment #8373840 - Flags: review?(doug.turner)
Comment on attachment 8373840 [details] [diff] [review]
v1

sorry that this sat so long.  blassey might be able to get to it before I can.
Attachment #8373840 - Flags: review?(dougt) → review?(blassey.bugs)
Rob, are the Windows 8 tablets making use of haptic feedback?
Flags: needinfo?(robert.strong.bugs)
Comment on attachment 8373840 [details] [diff] [review]
v1

Review of attachment 8373840 [details] [diff] [review]:
-----------------------------------------------------------------

Since these implementations are useless, they should definitely go. I do wonder if we actually want a working implementation on Desktop though.
Attachment #8373840 - Flags: review?(blassey.bugs) → review+
(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #4)
> Rob, are the Windows 8 tablets making use of haptic feedback?
I haven't been keeping track but Jim, Brian, or Matt should know.
Flags: needinfo?(robert.strong.bugs) → needinfo?(jmathies)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6)
> (In reply to Brad Lassey [:blassey] (use needinfo?) from comment #4)
> > Rob, are the Windows 8 tablets making use of haptic feedback?
> I haven't been keeping track but Jim, Brian, or Matt should know.

Win8 devices support this, but afaik it's only tied to the start button on some tablets, and isn't controllable through apis. 

I think if we found a use for this down the road we could put something together at that point.
Flags: needinfo?(jmathies)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.