Open
Bug 970770
Opened 10 years ago
Updated 2 years ago
Remove nsHapticFeedback on non-Android build
Categories
(Core :: DOM: Device Interfaces, defect, P3)
Tracking
()
NEW
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(1 file)
6.30 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
This interface was created by old Fennec, but... - Windows ports has skeleton nsHapticFeedback, but this isn't used because XPCOM interface isn't registered. - QT and GTK ports have same one, but it isn't built now. So we can remove it from tree. This is used for Fennec Android only.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → m_kato
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8373840 [details] [diff] [review] v1 Desktop version doesn't use this interface. We should remove it except to android. Also, unix directory becomes be used by Qt, so we should rename directory name from unix to qt.
Attachment #8373840 -
Flags: review?(doug.turner)
Comment 3•10 years ago
|
||
Comment on attachment 8373840 [details] [diff] [review] v1 sorry that this sat so long. blassey might be able to get to it before I can.
Attachment #8373840 -
Flags: review?(dougt) → review?(blassey.bugs)
Comment 4•10 years ago
|
||
Rob, are the Windows 8 tablets making use of haptic feedback?
Flags: needinfo?(robert.strong.bugs)
Comment 5•10 years ago
|
||
Comment on attachment 8373840 [details] [diff] [review] v1 Review of attachment 8373840 [details] [diff] [review]: ----------------------------------------------------------------- Since these implementations are useless, they should definitely go. I do wonder if we actually want a working implementation on Desktop though.
Attachment #8373840 -
Flags: review?(blassey.bugs) → review+
Comment 6•10 years ago
|
||
(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #4) > Rob, are the Windows 8 tablets making use of haptic feedback? I haven't been keeping track but Jim, Brian, or Matt should know.
Flags: needinfo?(robert.strong.bugs) → needinfo?(jmathies)
Comment 7•10 years ago
|
||
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6) > (In reply to Brad Lassey [:blassey] (use needinfo?) from comment #4) > > Rob, are the Windows 8 tablets making use of haptic feedback? > I haven't been keeping track but Jim, Brian, or Matt should know. Win8 devices support this, but afaik it's only tied to the start button on some tablets, and isn't controllable through apis. I think if we found a use for this down the road we could put something together at that point.
Flags: needinfo?(jmathies)
Updated•6 years ago
|
Priority: -- → P3
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•