970775 - CopyTex(Sub)Image2D can generate the wrong error

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

I was adding more asserts to various parts of WebGLFramebuffer, and started seeing an assert that we were asking whether a null attachment has alpha or not.

It looks like we will erroneously generate INVALID_OPERATION instead of INVALID_FRAMEBUFFER_OPERATION if the CopyTexImage2D is called while an FB with no color-attachment0 is bound, and our goal texture internalFormat has alpha, instead of generating INVALID_FB_OP because the FB is incomplete.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 1: More asserts

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 2: Fix CopyTex(Sub)Image

Comment 3

[Kelsey Gilbert [:jgilbert]]

Here's a clean try run:
https://tbpl.mozilla.org/?tree=Try&rev=4ef3916ba004

Comment 4

[Kelsey Gilbert [:jgilbert]]

A try run with the asserts, but not the fixup patch:
https://tbpl.mozilla.org/?tree=Try&rev=783cc0ae69c2

Note the asserts.

Comment 5

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8a7d2c8607c
https://hg.mozilla.org/integration/mozilla-inbound/rev/37b53e9bf06f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8a7d2c8607c
https://hg.mozilla.org/mozilla-central/rev/37b53e9bf06f