970814 - The network monitor's footer buttons (for sorting, clear, etc.) should use theme colors

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8374052 [details] [diff] [review]
v1

Review of attachment 8374052 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/netmonitor.inc.css
@@ +558,5 @@
> +}
> +
> +.theme-dark .requests-menu-footer-button:not(:active)[checked] {
> +  background-color: #1d4f73; /* Select Highlight Blue */
> +  color: #f5f7fa; /* Light foreground text */

I think we should be consisitent and use the rgba values for these.

Comment 3

[Victor Porof [:vporof][:vp]]

That file is anything but consistent! But ok.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v2

Addressed comments.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8374081 [details] [diff] [review]
v2

Review of attachment 8374081 [details] [diff] [review]:
-----------------------------------------------------------------

maybe you should fix the other entries to match!

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/e8e617ee5982

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8e617ee5982