970824 - [LockScreen][System] Stop directly use 'lockScreen.locked'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

If we make System as a instantiable function, we can use:

    <system instance reference>.states.locked

Instead of directly get the 'lockScreen' instance. This would help us to decouple the lockscreen.

This bug would depend on instantiable System bug.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Alive's opinion: use

    <system instance>.locked

to achieve this.

It still can forward the real lockscreen's property from different methods.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Travis is green:

https://travis-ci.org/mozilla-b2g/gaia/builds/20741476

Set the review flag.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll try to land this patch tomorrow (3/28).

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

I've prepared a new patch, and:

Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/27918809
TBPL all passed except one error that failed at every PR: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=546899efec4272c6817d136c1018ae6afdf2333b

So I set review again.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

New patch.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8442704 [details] [review]
Patch

I believe this is agreed in previous review so quick r+.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/fa1ecd7f9703b6061e6b0a63bc160069ebd91b1f

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master revert: https://github.com/mozilla-b2g/gaia/commit/cd00355bbf1f9ce1e4eb6c5af5cd05b29bde9d03

Comment 9

[Zac C (:zac)]

Hey why was this backed out?

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

I've found this is caused by an old 'will-unlock' event, which should be eliminated at Bug 1025723. I've fired another bug to handle these missed parts, but the patch was blocked by failed tests. So I'll fix it at this bug, and the patch now is waiting for the CI results.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch v2

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

The patch passed all tests except those failed at other PRs:

On Travis it always failed at one Music playback related test. For example:

https://travis-ci.org/mozilla-b2g/gaia/jobs/28807091
https://travis-ci.org/mozilla-b2g/gaia/jobs/28785695

On TBPL it failed at some integration tests. You can see it passed the previous failed test at the different re-try session:

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=929c7098c833edbecd5db949f5c70b725fe3dde3

The Vertical homescreen failure also occurs at other PRs. For example:

https://tbpl.mozilla.org/php/getParsedLog.php?id=42777342&tree=Gaia-Try

So I decide to land it, and to see if everything is okay.

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/c086196d647ba35135061a7882657e8d63a8d1a8