Open Bug 970890 Opened 12 years ago Updated 3 years ago

TURN TCP rather than TURN UDP selects

Categories

(Core :: WebRTC: Networking, defect, P5)

Product:
Core
Component:
WebRTC: Networking
Platform:
x86
macOS
Type:
defect

Tracking

()

Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: ekr, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Wait a little before checking that we're using TURN UDP if TURN TCP is in play.
1.63 KB, patch
Details | Diff | Splinter Review
See the following trace from my CI system. [ RUN ] IceConnectTest.TestSendReceiveTurnBothOnly Candidate initialized: candidate:0 1 UDP 2122252543 74.95.2.169 35353 typ host Candidate initialized: candidate:0 1 UDP 2122252543 74.95.2.169 59882 typ host Candidate initialized: candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546 Candidate initialized: candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941 Gathering complete for P2 CANDIDATES: Stream P2 candidate:0 1 UDP 2122252543 74.95.2.169 59882 typ host candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546 candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941 Candidate initialized: candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117 Candidate initialized: candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931 Gathering complete for P1 CANDIDATES: Stream P1 candidate:0 1 UDP 2122252543 74.95.2.169 35353 typ host candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117 candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931 Returning candidate: candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546 Returning candidate: candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941 Candidate: candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546 Candidate: candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941 Returning candidate: candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117 Returning candidate: candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931 Candidate: candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117 Candidate: candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931 Stream ready P2:stream0 ct=1 Begin list of candidate pairs [ Local --> host 74.95.2.169:59882 codeword=0umN Remote --> relay :33940 codeword=fo4m state = 2 priority = 396316767158141439 nominated = 0 selected = 0 codeword = Agl6 Local --> relay(udp) 74.95.2.169:59882 codeword=iA0A Remote --> relay :33940 codeword=fo4m state = 4 priority = 396316763098185727 nominated = 1 selected = 1 codeword = FCIL Local --> host 74.95.2.169:59882 codeword=0umN Remote --> relay :33940 codeword=GJqV state = 2 priority = 36028796968501759 nominated = 0 selected = 0 codeword = WbN+ Local --> relay(udp) 74.95.2.169:59882 codeword=iA0A Remote --> relay :33940 codeword=GJqV state = 2 priority = 36028792908546047 nominated = 1 selected = 0 codeword = 3Whe Local --> relay(tcp) 74.95.2.169:41090 codeword=4j+j Remote --> relay :33940 codeword=fo4m state = 2 priority = 36028792908546046 nominated = 1 selected = 0 codeword = Iv5a Local --> relay(tcp) 74.95.2.169:41090 codeword=4j+j Remote --> relay :33940 codeword=GJqV state = 2 priority = 36028792740773887 nominated = 0 selected = 0 codeword = 01mv ] ICE completed P2 Stream ready P1:stream0 ct=1 Begin list of candidate pairs [ Local --> host 74.95.2.169:35353 codeword=GT/Q Remote --> relay :25748 codeword=NOqp state = 2 priority = 396316767158141438 nominated = 0 selected = 0 codeword = b12J Local --> relay(udp) 74.95.2.169:35353 codeword=GI1P Remote --> relay :25748 codeword=NOqp state = 2 priority = 396316763098185727 nominated = 0 selected = 0 codeword = +ml5 Local --> host 74.95.2.169:35353 codeword=GT/Q Remote --> relay :25748 codeword=Lt46 state = 2 priority = 36028796968501758 nominated = 0 selected = 0 codeword = QHJN Local --> relay(tcp) 74.95.2.169:54779 codeword=Iq2b Remote --> relay :25748 codeword=NOqp state = 4 priority = 36028792908546047 nominated = 1 selected = 1 codeword = Sj4D Local --> relay(udp) 74.95.2.169:35353 codeword=GI1P Remote --> relay :25748 codeword=Lt46 state = 2 priority = 36028792908546046 nominated = 0 selected = 0 codeword = nvm8 Local --> relay(tcp) 74.95.2.169:54779 codeword=Iq2b Remote --> relay :25748 codeword=Lt46 state = 2 priority = 36028792740773887 nominated = 0 selected = 0 codeword = Vsuh ] ICE completed P1 Active candidates: Stream 0 component 1 Local --> relay(tcp) 74.95.2.169:54779 codeword=Iq2b /home/buildslave/work/ubuntu12_04_64/build/media/mtransport/test/ice_unittest.cpp:414: Failure Value of: local->local_addr.transport Actual: "tcp" Expected: expected_local_transport_ Which is: "udp" ICE(P1): No STUN servers specified ICE(P1): No TURN servers specified ICE(P2): No STUN servers specified ICE(P2): No TURN servers specified ICE(P1): duplicate priority 1686110207 candidate srflx(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:3478/UDP) and candidate srflx(IP4:74.95.2.169:35353/UDP|IP4:23.21.150.121:3478/UDP) ICE(P2): duplicate priority 1686110207 candidate srflx(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:3478/UDP) and candidate srflx(IP4:74.95.2.169:59882/UDP|IP4:23.21.150.121:3478/UDP) Inconsistent message method: 113 expected 001 Inconsistent message method: 113 expected 001 Skipping SOURCE-ADDRESS Skipping CHANGED-ADDRESS Translating obsolete XOR-MAPPED-ADDRESS type Skipping SOURCE-ADDRESS Skipping CHANGED-ADDRESS Translating obsolete XOR-MAPPED-ADDRESS type TURN(relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:3478/UDP)): Succesfully allocated addr IP4:54.245.170.175:49546/UDP lifetime=600 TURN(relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:3478/TCP)): Succesfully allocated addr IP4:54.245.170.175:58941/UDP lifetime=600 TURN(relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:3478/UDP)): Succesfully allocated addr IP4:54.245.170.175:53117/UDP lifetime=600 TURN(relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:3478/TCP)): Succesfully allocated addr IP4:54.245.170.175:33931/UDP lifetime=600 ICE-PEER(P1:default)/CAND-PAIR(b12J): setting pair to state FROZEN: b12J|IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:49546/UDP(host(IP4:74.95.2.169:35353/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE(P1)/CAND-PAIR(b12J): Pairing candidate IP4:74.95.2.169:35353/UDP (7e7f00ff):IP4:54.245.170.175:49546/UDP (57fffff) priority=396316767158141438 (57ffffffcfe01fe) ICE-PEER(P1:default)/CAND-PAIR(QHJN): setting pair to state FROZEN: QHJN|IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:58941/UDP(host(IP4:74.95.2.169:35353/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE(P1)/CAND-PAIR(QHJN): Pairing candidate IP4:74.95.2.169:35353/UDP (7e7f00ff):IP4:54.245.170.175:58941/UDP (7fffff) priority=36028796968501758 (7ffffffcfe01fe) ICE-PEER(P1:default)/CAND-PAIR(+ml5): setting pair to state FROZEN: +ml5|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE(P1)/CAND-PAIR(+ml5): Pairing candidate IP4:54.245.170.175:53117/UDP (57fffff):IP4:54.245.170.175:49546/UDP (57fffff) priority=396316763098185727 (57fffff0affffff) ICE-PEER(P1:default)/CAND-PAIR(nvm8): setting pair to state FROZEN: nvm8|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE(P1)/CAND-PAIR(nvm8): Pairing candidate IP4:54.245.170.175:53117/UDP (57fffff):IP4:54.245.170.175:58941/UDP (7fffff) priority=36028792908546046 (7fffff0afffffe) ICE-PEER(P1:default)/CAND-PAIR(Sj4D): setting pair to state FROZEN: Sj4D|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE(P1)/CAND-PAIR(Sj4D): Pairing candidate IP4:54.245.170.175:33931/UDP (7fffff):IP4:54.245.170.175:49546/UDP (57fffff) priority=36028792908546047 (7fffff0affffff) ICE-PEER(P1:default)/CAND-PAIR(Vsuh): setting pair to state FROZEN: Vsuh|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE(P1)/CAND-PAIR(Vsuh): Pairing candidate IP4:54.245.170.175:33931/UDP (7fffff):IP4:54.245.170.175:58941/UDP (7fffff) priority=36028792740773887 (7fffff00ffffff) ICE-PEER(P1:default)/CAND-PAIR(b12J): setting pair to state WAITING: b12J|IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:49546/UDP(host(IP4:74.95.2.169:35353/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P1:default)/CAND-PAIR(+ml5): setting pair to state WAITING: +ml5|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P1:default)/CAND-PAIR(QHJN): setting pair to state WAITING: QHJN|IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:58941/UDP(host(IP4:74.95.2.169:35353/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P1:default)/CAND-PAIR(Sj4D): setting pair to state WAITING: Sj4D|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P1:default)/CAND-PAIR(nvm8): setting pair to state WAITING: nvm8|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P1:default)/CAND-PAIR(Vsuh): setting pair to state WAITING: Vsuh|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P1:default)/CAND-PAIR(b12J): setting pair to state IN_PROGRESS: b12J|IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:49546/UDP(host(IP4:74.95.2.169:35353/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE(P1): peer (P1:default) no streams with pre-answer requests ICE-PEER(P2:default)/CAND-PAIR(Agl6): setting pair to state FROZEN: Agl6|IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:53117/UDP(host(IP4:74.95.2.169:59882/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE(P2)/CAND-PAIR(Agl6): Pairing candidate IP4:74.95.2.169:59882/UDP (7e7f00ff):IP4:54.245.170.175:53117/UDP (57fffff) priority=396316767158141439 (57ffffffcfe01ff) ICE-PEER(P2:default)/CAND-PAIR(WbN+): setting pair to state FROZEN: WbN+|IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:33931/UDP(host(IP4:74.95.2.169:59882/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE(P2)/CAND-PAIR(WbN+): Pairing candidate IP4:74.95.2.169:59882/UDP (7e7f00ff):IP4:54.245.170.175:33931/UDP (7fffff) priority=36028796968501759 (7ffffffcfe01ff) ICE-PEER(P2:default)/CAND-PAIR(FCIL): setting pair to state FROZEN: FCIL|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE(P2)/CAND-PAIR(FCIL): Pairing candidate IP4:54.245.170.175:49546/UDP (57fffff):IP4:54.245.170.175:53117/UDP (57fffff) priority=396316763098185727 (57fffff0affffff) ICE-PEER(P2:default)/CAND-PAIR(3Whe): setting pair to state FROZEN: 3Whe|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE(P2)/CAND-PAIR(3Whe): Pairing candidate IP4:54.245.170.175:49546/UDP (57fffff):IP4:54.245.170.175:33931/UDP (7fffff) priority=36028792908546047 (7fffff0affffff) ICE-PEER(P2:default)/CAND-PAIR(Iv5a): setting pair to state FROZEN: Iv5a|IP4:54.245.170.175:58941/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:58941/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE(P2)/CAND-PAIR(Iv5a): Pairing candidate IP4:54.245.170.175:58941/UDP (7fffff):IP4:54.245.170.175:53117/UDP (57fffff) priority=36028792908546046 (7fffff0afffffe) ICE-PEER(P2:default)/CAND-PAIR(01mv): setting pair to state FROZEN: 01mv|IP4:54.245.170.175:58941/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:58941/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE(P2)/CAND-PAIR(01mv): Pairing candidate IP4:54.245.170.175:58941/UDP (7fffff):IP4:54.245.170.175:33931/UDP (7fffff) priority=36028792740773887 (7fffff00ffffff) ICE-PEER(P2:default)/CAND-PAIR(Agl6): setting pair to state WAITING: Agl6|IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:53117/UDP(host(IP4:74.95.2.169:59882/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/CAND-PAIR(FCIL): setting pair to state WAITING: FCIL|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/CAND-PAIR(WbN+): setting pair to state WAITING: WbN+|IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:33931/UDP(host(IP4:74.95.2.169:59882/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P2:default)/CAND-PAIR(3Whe): setting pair to state WAITING: 3Whe|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P2:default)/CAND-PAIR(Iv5a): setting pair to state WAITING: Iv5a|IP4:54.245.170.175:58941/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:58941/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/CAND-PAIR(01mv): setting pair to state WAITING: 01mv|IP4:54.245.170.175:58941/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:58941/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P2:default)/CAND-PAIR(Agl6): setting pair to state IN_PROGRESS: Agl6|IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:53117/UDP(host(IP4:74.95.2.169:59882/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE(P2): peer (P2:default) no streams with pre-answer requests ICE-PEER(P1:default)/CAND-PAIR(+ml5): setting pair to state IN_PROGRESS: +ml5|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) TURN(relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:3478/UDP)): Creating permission for IP4:54.245.170.175:49546/UDP ICE-PEER(P2:default)/CAND-PAIR(FCIL): setting pair to state IN_PROGRESS: FCIL|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) TURN(relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:3478/UDP)): Creating permission for IP4:54.245.170.175:53117/UDP Skipping SOURCE-ADDRESS Skipping CHANGED-ADDRESS Translating obsolete XOR-MAPPED-ADDRESS type Skipping SOURCE-ADDRESS Skipping CHANGED-ADDRESS Translating obsolete XOR-MAPPED-ADDRESS type ICE-PEER(P1:default)/CAND-PAIR(QHJN): setting pair to state IN_PROGRESS: QHJN|IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:58941/UDP(host(IP4:74.95.2.169:35353/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P2:default)/CAND-PAIR(WbN+): setting pair to state IN_PROGRESS: WbN+|IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:33931/UDP(host(IP4:74.95.2.169:59882/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P1:default)/CAND-PAIR(Sj4D): setting pair to state IN_PROGRESS: Sj4D|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) TURN(relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:3478/TCP)): Creating permission for IP4:54.245.170.175:49546/UDP ICE-PEER(P2:default)/CAND-PAIR(3Whe): setting pair to state IN_PROGRESS: 3Whe|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P1:default)/CAND-PAIR(nvm8): setting pair to state IN_PROGRESS: nvm8|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P2:default)/CAND-PAIR(Iv5a): setting pair to state IN_PROGRESS: Iv5a|IP4:54.245.170.175:58941/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:58941/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) TURN(relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:3478/TCP)): Creating permission for IP4:54.245.170.175:53117/UDP ICE-PEER(P1:default)/CAND-PAIR(Vsuh): setting pair to state IN_PROGRESS: Vsuh|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P2:default)/CAND-PAIR(01mv): setting pair to state IN_PROGRESS: 01mv|IP4:54.245.170.175:58941/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:58941/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P1:default): no pairs for P1:stream0 ICE-PEER(P2:default): no pairs for P2:stream0 ICE-PEER(P2:default)/CAND-PAIR(3Whe): triggered check on 3Whe|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P1:default)/CAND-PAIR(nvm8): triggered check on nvm8|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P1:default)/CAND-PAIR(Vsuh): triggered check on Vsuh|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:58941/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 58941 typ relay raddr 54.245.170.175 rport 58941) ICE-PEER(P1:default)/CAND-PAIR(+ml5): triggered check on +ml5|IP4:54.245.170.175:53117/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:35353/UDP|IP4:54.245.170.175:53117/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P2:default)/CAND-PAIR(3Whe): triggered check on 3Whe|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:33931/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:4 1 UDP 8388607 54.245.170.175 33931 typ relay raddr 54.245.170.175 rport 33931) ICE-PEER(P2:default)/CAND-PAIR(FCIL): triggered check on FCIL|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/CAND-PAIR(Iv5a): triggered check on Iv5a|IP4:54.245.170.175:58941/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:41090/TCP|IP4:54.245.170.175:58941/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/CAND-PAIR(FCIL): setting pair to state SUCCEEDED: FCIL|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/STREAM(P2:stream0)/COMP(1)/CAND-PAIR(FCIL): nominated pair is FCIL|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/STREAM(P2:stream0)/COMP(1)/CAND-PAIR(FCIL): cancelling all pairs but FCIL|IP4:54.245.170.175:49546/UDP|IP4:54.245.170.175:53117/UDP(turn-relay(IP4:74.95.2.169:59882/UDP|IP4:54.245.170.175:49546/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 53117 typ relay raddr 54.245.170.175 rport 53117) ICE-PEER(P2:default)/ICE-STREAM(P2:stream0): all active components have nominated candidate pairs ICE-PEER(P2:default): all checks completed success=1 fail=0 ICE-PEER(P1:default)/CAND-PAIR(Sj4D): triggered check on Sj4D|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P1:default)/CAND-PAIR(Sj4D): setting pair to state SUCCEEDED: Sj4D|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P1:default)/STREAM(P1:stream0)/COMP(1)/CAND-PAIR(Sj4D): nominated pair is Sj4D|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P1:default)/STREAM(P1:stream0)/COMP(1)/CAND-PAIR(Sj4D): cancelling all pairs but Sj4D|IP4:54.245.170.175:33931/UDP|IP4:54.245.170.175:49546/UDP(turn-relay(IP4:74.95.2.169:54779/TCP|IP4:54.245.170.175:33931/UDP)|candidate:3 1 UDP 92274687 54.245.170.175 49546 typ relay raddr 54.245.170.175 rport 49546) ICE-PEER(P1:default)/ICE-STREAM(P1:stream0): all active components have nominated candidate pairs ICE-PEER(P1:default): all checks completed success=1 fail=0 Active candidates: Stream 0 component 1 Local --> relay(udp) 74.95.2.169:59882 codeword=iA0A Remote --> relay :0 codeword=fo4m Sent 4 bytes Received 4 bytes [ FAILED ] IceConnectTest.TestSendReceiveTurnBothOnly (2476 ms)
Assignee: nobody → docfaraday
Ok, so I see one end selecting UDP, and the other TCP. I can't really tell what is going on here without a little more logging (specifically of STUN responses).
My hypothesis here is that the test just doesn't wait long enough for things to settle; we'll nominate pairs as they are found to work, and if something better works later we'll switch.
That could be true. Shall we try adding a wait to the end?
I am loathe to add a wait to a test-case unless I'm almost completely positive that it fixes the real issue, doesn't mask other issues, and there is no other practical way. Also, if we see packet loss, adding a wait won't help us, because we stop sending check requests once we nominate. Maybe there needs to be a grace period where we continue to send check requests after nomination (or maybe something like don't cancel stuff that has sent only one check request so far)?
(In reply to Byron Campen [:bwc] from comment #4) > I am loathe to add a wait to a test-case unless I'm almost completely > positive that it fixes the real issue, doesn't mask other issues, and there > is no other practical way. Also, if we see packet loss, adding a wait won't > help us, because we stop sending check requests once we nominate. Maybe > there needs to be a grace period where we continue to send check requests > after nomination (or maybe something like don't cancel stuff that has sent > only one check request so far)? You actually don't cancel *all* the checks. You only are supposed to cancel checks that are lower priority and not in progress. So it might actually auto-correct.
(In reply to Eric Rescorla (:ekr) from comment #5) > (In reply to Byron Campen [:bwc] from comment #4) > > I am loathe to add a wait to a test-case unless I'm almost completely > > positive that it fixes the real issue, doesn't mask other issues, and there > > is no other practical way. Also, if we see packet loss, adding a wait won't > > help us, because we stop sending check requests once we nominate. Maybe > > there needs to be a grace period where we continue to send check requests > > after nomination (or maybe something like don't cancel stuff that has sent > > only one check request so far)? > > You actually don't cancel *all* the checks. You only are supposed to cancel > checks that are lower priority and not in progress. So it might actually > auto-correct. Ok, then that should be fine.
Attachment #8378458 - Flags: review?(ekr)
Status: NEW → ASSIGNED
Attachment #8378458 - Flags: review?(ekr)
Looking at this code, I'm not sure why it would help. We don't check the candidates till after ICE has transitioned to ice_complete() at which point there probably shouldn't be any checks going on and so the candidate pairs shouldn't change. Do you have a theory for how this could happen?
Flags: needinfo?(docfaraday)
(In reply to Eric Rescorla (:ekr) from comment #9) > Looking at this code, I'm not sure why it would help. We don't check the > candidates till after ICE has transitioned to ice_complete() at which point > there probably shouldn't be any checks going on and so the candidate pairs > shouldn't change. Do you have a theory for how this could happen? ice_complete() fires as soon as every component has a nominated pair; checks continue afterward, and new nominations can occur.
Flags: needinfo?(docfaraday)
So maybe we should solve this problem instead by adding a new state that is like "no checks happening". Note that the specification requires that we be able to distinguish these states: http://dev.w3.org/2011/webrtc/editor/webrtc.html#rtciceconnectionstate-enum
That is ultimately something we need to do, yes. Let me file a ticket.
Depends on: 984580
backlog: --- → webRTC+
Rank: 55
Priority: -- → P5
Assignee: docfaraday → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: