Fix intermittent failure in test_gallery_empty.py

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: viorela, Assigned: viorela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The above test fails in teh latest build with this error:
Traceback (most recent call last):
  File "/home/viorelaioia/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_empty.py", line 22, in test_empty_gallery
    self.assertEqual(gallery.empty_gallery_title, 'No photos or videos')
TEST-UNEXPECTED-FAIL | test_gallery_empty.py test_gallery_empty.TestGalleryEmpty.test_empty_gallery | AssertionError: u'' != 'No photos or videos'
(Assignee)

Updated

4 years ago
Assignee: nobody → viorela.ioia
(Assignee)

Comment 1

4 years ago
Created attachment 8374076 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/16174
Attachment #8374076 - Flags: review?(zcampbell)
Attachment #8374076 - Flags: review?(florin.strugariu)
Attachment #8374076 - Flags: review?(florin.strugariu) → review+

Comment 2

4 years ago
Comment on attachment 8374076 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/16174

I am not convinced of this fix.

The field here is used for more than just the empty text. You can see here in a loop output of the text content it can have more than 1 value.

In this test I think it would be safer to wait for the content to be what we expect rather and replace the assertion.

------------------
test_empty_gallery (test_gallery_empty.TestGalleryEmpty)
https://moztrap.mozilla.org/manage/case/4003/ ... 




Looking for photos and videos.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
Use the Camera app to get started.
ok

----------------------------------------------------------------------
Ran 1 test in 45.204s
Attachment #8374076 - Flags: review?(zcampbell) → review-
(Assignee)

Updated

4 years ago
Attachment #8374076 - Flags: review- → review?(zcampbell)

Comment 3

4 years ago
Comment on attachment 8374076 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/16174

r+!
Attachment #8374076 - Flags: review?(zcampbell) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.