Dump more informations on the console about the source of the reflow

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vingtetun, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

With the new widget panel it is hard to know which app has fired a reflow. I used to know this information by looking at the source PID of the message in logcat but now all the PIDs are hidden since the messages are displayed by the master process.

Having a bit more sugar would be definitively nice.
Created attachment 8374095 [details] [diff] [review]
moreinfo.reflow.dump.patch
Attachment #8374095 - Flags: review?(paul)

Comment 2

5 years ago
Comment on attachment 8374095 [details] [diff] [review]
moreinfo.reflow.dump.patch

This should not be reflow specific. Also, no need to change the actor. We're supposed to know the origin from this._app.

Jan, what do you think?
Attachment #8374095 - Flags: review?(paul) → review-
Flags: needinfo?(janx)
First, I'm curious why you need app-origin information in the console, because the widgets already show where reflows happen. Is it to disambiguate keyboard reflow information from app reflows? Or to detect reflows in the system app?

Second, you can use `app.manifest` to get the manifestURL, but I'm not sure you'll be able to get pageURL without modifying the actor. 

Maybe you could prepend this context information to `output` before the switch, so that all console metrics benefit from it?
Flags: needinfo?(janx)
(In reply to Jan Keromnes [:janx] from comment #3)
> First, I'm curious why you need app-origin information in the console,
> because the widgets already show where reflows happen. Is it to disambiguate
> keyboard reflow information from app reflows? Or to detect reflows in the
> system app?

Yeah that's mostly to disambiguate. I used to look at the reflows in the console to get the times it has took and not beeing able to know what is the source of reflows makes it painful sometimes.

> 
> Second, you can use `app.manifest` to get the manifestURL, but I'm not sure
> you'll be able to get pageURL without modifying the actor. 
>

I think I can live without the pageURL. I dump'ed it at first to see if some of the reflows logged came from about:blank for the template app.
 
> Maybe you could prepend this context information to `output` before the
> switch, so that all console metrics benefit from it?

Will use the app.manifest stuff. Sounds much better. Thanks :)
Unless you really need pageURL info, this was fixed in bug #973188 by adding manifestURL to each metric change log.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.