970973 - Empty space in toolbar where lock icon would go

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: screenshot

I ran into this last night, and the empty space stayed there even as I switched tabs and navigated to other pages.

I can't reproduce right now, but I'll pay attention to see if I run into this again. At the time, I was opening links from Twitter, so maybe something with loading external URLs triggered this?

Comment 1

[u421692]

There was a similar issue logged a while ago in bug 867608 and bug 873086. I'll look into this and see if I can reproduce.

Comment 2

[Lucas Rocha (:lucasr)]

Mihai, any luck reproducing this bug?

Comment 3

[u421692]

Tried on several devices, and different scenarios but no luck reproducing this issue.

Comment 4

[:Margaret Leibovic]

I was the one who originally filed this bug, and I haven't seen this again, so I'm closing as WORKSFORME. I can reopen if I see it happen again.

Comment 5

[Teodora Vermesan (:TeoVermesan)]

Attachment: Empty_Space_Beta.png

Device: LG Nexus 4 (Android 4.4.2)
Build: Firefox for Android 29 Beta 2 (2014-03-25)

I ran into this, but I don't have steps to reproduce.

Comment 6

[u421692]

Still reproducing on latest Nightly 31.0a1(2014-04-09), unfortunately haven't got the steps to reproduce

Comment 8

[Wesley Johnston (:wesj)]

STR from bnicholson in bug 994339: Do a search and create a new tab before the lock icon appears. See screenshot.

Comment 9

[Brian Nicholson (:bnicholson)]

Can reproduce in beta, but not release.

Comment 10

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Attachment: Prevent empty space in security identity.

It seems the issue was the favicon animation would start, but when disabling animations while switching tabs, we only changed the security visibility, rather than cancelling the animation, which sets the page title position, thus the position was never reset, and the gap was shown.

Comment 11

[Lucas Rocha (:lucasr)]

Comment on attachment 8406343 [details] [diff] [review]
Prevent empty space in security identity.

Review of attachment 8406343 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 12

[Michael Comella (:mcomella) [needinfo or I won't see it]]

https://hg.mozilla.org/integration/fx-team/rev/e2b517f57867

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2b517f57867

Comment 14

[u421692]

Verified as fixed on Nightly 31.0a1(2014-04-16) using the STR from bnicholson. Will this be uplifted to aurora and beta?

Comment 15

[Michael Comella (:mcomella) [needinfo or I won't see it]]

(In reply to Mihai Pop from comment #14)
> Verified as fixed on Nightly 31.0a1(2014-04-16) using the STR from
> bnicholson. Will this be uplifted to aurora and beta?

While it seems fairly harmless to uplift to Beta, I don't think we have enough time to let it comfortably ride the trains. It doesn't appear to be a significant issue (I don't think I've ever repro'd in the wild) so I think uplifting to just Aurora would be fine. Thank you for the reminder.

Comment 16

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Comment on attachment 8406343 [details] [diff] [review]
Prevent empty space in security identity.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Unknown.

User impact if declined:
  While quickly changing tabs, users may see an empty space in the toolbar. As far as I know, this should only happen on non-secure sites, meaning there is no loss in functionality (besides a few missing page title characters) - it just looks unpolished. See the attached screenshots.

Testing completed (on m-c, etc.):
  Local testing.
 
Risk to taking this patch (and alternatives if risky):
  Low - this patch performs animation cancellation everytime this lock icon should be set visible or invisible, as opposed to only when a particular flag is not set, so worst comes to worst, some UI mechanic screws up in another edge case and it looks less polished.

String or IDL/UUID changes made by this patch: N/A

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8406343 [details] [diff] [review]
Prevent empty space in security identity.

Correct - we are out of time for Beta.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/39276205c485

Comment 19

[u421692]

Verified as fixed on Aurora 30.0a2(2014-04-18) on Alcatel One Touch (Android 4.1.2).