970995 - Activate devtools-layers tracking for the system app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

We still miss a good way to display it in Gaia but at least it will let us use it from logcat for now.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug.tracking.systemapp.patch

Comment 2

[Jan Keromnes [:janx]]

Vivien, did you say you get a crash on the new trackApp() call?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jan Keromnes [:janx] from comment #2)
> Vivien, did you say you get a crash on the new trackApp() call?

It has not crashed but I was getting some errors. Now it works fine.

I wonder if there is a new kind of cache mechanism on the device because I had to .|/build.sh gecko && ./flash.sh gecko| instead of the usual small script I'm running.

Apparently paul is doing |adb shell rm -r /data/b2g/mozilla/*.default/startupCache| for some cache issue too those days.

Comment 4

[Jan Keromnes [:janx]]

Comment on attachment 8374134 [details] [diff] [review]
bug.tracking.systemapp.patch

Review of attachment 8374134 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me.

Note that tracking the System App will cause the widget-creating code in Gaia to silently fail, because it will fail to querySelect iframe[mozapp=" + systemappURL + "]. Thus, until we find a good place to display the widgets, only the logcat output will be useable for the System App.

::: b2g/chrome/content/devtools.js
@@ +66,5 @@
> +        let systemapp = document.querySelector('#systemapp');
> +        let manifestURL = systemapp.getAttribute("mozapp");
> +        this.trackApp(manifestURL);
> +
> +        let frames = systemapp.contentWindow.document.querySelectorAll('iframe[mozapp]');

Nit: I think this line is too long.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jan Keromnes [:janx] from comment #4)
> Comment on attachment 8374134 [details] [diff] [review]
> bug.tracking.systemapp.patch
> 
> Review of attachment 8374134 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Fine by me.
> 
> Note that tracking the System App will cause the widget-creating code in
> Gaia to silently fail, because it will fail to querySelect iframe[mozapp=" +
> systemappURL + "]. Thus, until we find a good place to display the widgets,
> only the logcat output will be useable for the System App.

That's fine to me since we need to fix bug 971008 to not ends up into an infinite loop :)
> 
> ::: b2g/chrome/content/devtools.js
> @@ +66,5 @@
> > +        let systemapp = document.querySelector('#systemapp');
> > +        let manifestURL = systemapp.getAttribute("mozapp");
> > +        this.trackApp(manifestURL);
> > +
> > +        let frames = systemapp.contentWindow.document.querySelectorAll('iframe[mozapp]');
> 
> Nit: I think this line is too long.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc09cccba55c

Comment 7

[Jan Keromnes [:janx]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #5)
> That's fine to me since we need to fix bug 971008 to not ends up into an
> infinite loop :)

True. I wonder if it'll be easy to make the devtools layers completely reflow-free while they become more complex over time.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fc09cccba55c