971049 - Force app resubmissions (IARC-disabled apps) to get an IARC rating

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P4)

Description

[Andrew Williamson [:eviljeff]]

Currently, it appears that rejected apps are able to be resubmited, or a new version submitted, without being forced to get an IARC rating.  We should stop that.

In the short term it will force a few more developers to get their ratings; in the long term, when we go through and reject all apps that don't have a rating, we will need a way to stop them from just resubmitting them again.

marking blocking bug 929812 but feel free to change to a more relevant bug if there is one.

Comment 1

[Kevin Ngo [:ngoke]]

Our plan with previously existing apps was to allow them to go through, but force them to get a rating else they get disabled on the magic April 15th date. After submission, they'll be nagged about getting a rating through various means (emails, message on top of app devhub page).

So in a sense, they will be forced to get a rating, but we won't to spend time hard-coding anything in.

Comment 2

[Andrew Williamson [:eviljeff]]

(In reply to Kevin Ngo [:ngoke] from comment #1)
> Our plan with previously existing apps was to allow them to go through, but
> force them to get a rating else they get disabled on the magic April 15th
> date. 

exactly, so this is the 'force' part.

> After submission, they'll be nagged about getting a rating through
> various means (emails, message on top of app devhub page).

only after submission, though, as we don't email nag rejected apps.

> So in a sense, they will be forced to get a rating, but we won't to spend
> time hard-coding anything in.

it doesn't address "in the long term, when we go through and reject all apps that don't have a rating, we will need a way to stop them from just resubmitting them again." though - after April 15 we will want some way to allow them to resubmit but force them to get the rating.  I'm assuming the plan is to change them to REJECTED, but I've not seen any bugs logs either way.

Comment 3

[Kevin Ngo [:ngoke]]

Okay, I see your point. After we do the purge, we need to restrict resubmission on existing apps by requiring content ratings.

Comment 4

[Kevin Ngo [:ngoke]]

I'm thinking we should add another app status. Apps that were public but were disabled solely due to not getting content ratings on time:

STATUS_DISABLED_IARC

That way once they get attain content ratings, they can automatically be reset to STATUS_PUBLIC. If we set them to reject, reviewers would to review every single app again.

Comment 5

[Andrew Williamson [:eviljeff]]

I worry about adding another status that has to be taken into account all over the place, but I see the advantage.

Comment 6

[Kevin Ngo [:ngoke]]

Good point.

Let's see, I can add an IARC-disabled flag to Geodata.

When we purge the apps, we will set them to DISABLED (so there is no resubmit dialog on the status page).

If the app has an IARC-disabled flag, we will mention content ratings on the status page under the disabled message.

Once they attain content ratings, we will automatically reapprove the app if it has the IARC-disabled flag.

How does that sound?

Comment 7

[Andrew Williamson [:eviljeff]]

It sounds okay.

We probably don't need this long term - after, say, a year the IARC-disabled flag could be removed and any such special case code removed.

Comment 8

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/1852

Comment 9

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/1852/

STR: 

1. Submit an app.
2. Set its status to STATUS_DISABLED.
3. Try to resubmit it.

Expected:

Cannot resubmit without getting content ratings first.

4. Get content ratings.
5. Can resubmit.

Comment 10

[Kevin Ngo [:ngoke]]

Found an easier STR:

1. Disable a public app without content ratings.
2. Try to resubmit it.

...

Comment 11

[Iulian Timis]

I was able to resubmit the app with no issues on both MP-dev and MP-stage.
Please see screencast http://screencast.com/t/bQO8XD60e

Comment 12

[Kevin Ngo [:ngoke]]

Sorry for the confusion, you have to try to resubmit an app that *doesn't* have content ratings. Then it shouldn't work.

Comment 13

[Iulian Timis]

Verified as fixed in https://marketplace.allizom.org/developers/ on FF31 (Win 7).
Postfix screencast http://screencast.com/t/Rag3fcZ5b
Closing bug.