Closed Bug 971072 Opened 11 years ago Closed 11 years ago

[VDR] [BB] update modals with new Buttons BB

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S4 (28mar)

People

(Reporter: arnau, Assigned: arnau)

References

Details

Attachments

(4 files, 1 obsolete file)

action_menu.png
68.06 KB, image/png
vicky
: ui-review+
Details
value_selector.png
74.37 KB, image/png
vicky
: ui-review+
Details
confirm.png
64.51 KB, image/png
vicky
: ui-review+
Details
patch in github
46 bytes, text/x-github-pull-request
pivanov
: review+
Details | Review 
      No description provided.
Assignee: nobody → arnau
Depends on: 967843
Attached image action_menu.png — 

  

  



        Attachment #8374197 -
        Flags: ui-review?(vpg)

    
    

    
  

      
      
      
      

        Attached image
          
        value_selector.png
        — 
      

    


  

  

  



        Attachment #8374198 -
        Flags: ui-review?(vpg)

    
    

    
  

      
      
      
      

        Attached image
          
        confirm.png
        — 
      

    


  

  

  



        Attachment #8374199 -
        Flags: ui-review?(vpg)

    
    

    
  

      
      
      
      

        Attached file
          
        patch in github (obsolete)
        — 
      

    


  

  

  



        Attachment #8374204 -
        Flags: review?(pivanov)

        Attachment #8374197 -
        Flags: ui-review?(vpg) → ui-review+

        Attachment #8374199 -
        Flags: ui-review?(vpg) → ui-review+
Blocks: 965889

        Attachment #8374204 -
        Flags: review?(pivanov) → review+

    
    

    
  

      
      
      
      

        Attached file
          
        patch in github
        — 
      

    


  
Pavel, looks like something went wrong with my PR while trying to rebase, could you please review it again?

  

  



        Attachment #8374204 -
        Attachment is obsolete: true

        Attachment #8397103 -
        Flags: review?(pivanov)

    
    

    
  
Comment on attachment 8397103 [details] [review]
patch in github

Just one comment on github ... otherwise looks good

  

  



        Attachment #8397103 -
        Flags: review?(pivanov) → review+

    
    

    
  
Thanks Pavel, fixed your comment.

  

  



    
    

    
  
Merged: a04c6d8398d9c790d804cfb87d7a57d8e5a734f4

  

  


Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)

        Attachment #8374198 -
        Flags: ui-review?(vpg) → ui-review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: