2.52 MB, image/png
1.72 MB, image/png
39 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
3.17 KB, application/zip
Redesign of image capture/video record buttons Will attach visual specs
I took this bug yesterday and already start to work on it https://bugzilla.mozilla.org/show_bug.cgi?id=971510 Is it ok for you if I take this as well?
dmarcos: I thought you were working on the build time configuration for the new settings architecture (bug 965486). Lack of this feature is a serious blocker for v1.4 as it means partners cannot configure the camera app is the current way. This bug aligns well with my skill-set, plus I've already implemented the proof of concept in my 'controls-refresh' branch, which I've begun porting across. bug 971510 isn't a blocker for v1.4 as Mozilla camera may not have a visible settings menu. We don't have much dev time left in v1.4, especially with the upcoming work week, I'm concerned we won't have ticked off our blockers :-/
Created attachment 8378420 [details] [review] PR - Work in progress
Attachment #8378420 - Flags: feedback?(wilsonpage)
Comment on attachment 8378420 [details] [review] PR - Work in progress r+ under the condition raised comments (Github) are addressed :)
Attachment #8378420 - Flags: feedback?(wilsonpage) → feedback+
Created attachment 8379195 [details] CSS_Pixels_Single_Shutter_Camera_Spec.png Single shutter - camera toggle spec
Created attachment 8379210 [details] video_toggle_icon.svg
Attachment #8379204 - Attachment is obsolete: true
Created attachment 8379211 [details] camera_toggle_icon.svg
Attachment #8379205 - Attachment is obsolete: true
Created attachment 8379248 [details] CSS_Pixels_Single_Shutter_Video_Spec.png Spec for single shutter video toggle
Created attachment 8379249 [details] CSS_Pixels_Single_Shutter_Camera_Spec.png Single shutter camera toggle
Attachment #8379195 - Attachment is obsolete: true
Created attachment 8382918 [details] [review] Pull Request
Attachment #8378420 - Attachment is obsolete: true
Hi Diego, Can you check the single shutter spec for the correct image grid button? Icon should be 3x3 rems and a semi-transparent 54x54px circle behind it. Also the image capture button looks off centered. Can you look through the spec to check the spacing of the controls? Thanks!
It's not finalized. We'll be requesting ui review when those patches are final.
Created attachment 8385832 [details] [review] pull-request (camera-new-features)
Attachment #8385832 - Flags: review?(dflanagan)
I've started reviewing this and have preliminary comments on github, but not done. I don't see any of the attached images in the pull request. Are they already in the icon font perhaps?
Amy, The svg images you have attached are all > 100kb because they contain an encoded binary raster version of the image in addition to this nice clean svg image. This has been a problem on other bugs as well. Do you have a way to export your svg so that it is small and clean?
Created attachment 8386530 [details] SVG_Icons.zip Hi David, I've re-exported the icons and got them down to around 1KB. Let me know if these work for you and I'll do the same for the rest of the camera app icons.
Comment on attachment 8385832 [details] [review] pull-request (camera-new-features) r- mainly for issues related to the thumbnail: you need to base it on the EXIF preview so you don't decode the full-size image. Also, you don't create a video thumbnails. I've left a lot of other comments on the commit as well.
Attachment #8385832 - Flags: review?(dflanagan) → review-
Attachment #8385832 - Flags: review- → review?(dflanagan)
Comment on attachment 8385832 [details] [review] pull-request (camera-new-features) I have not had time to run the code, so I don't know what the new controls look like, but the code looks great. I've commented on a few nits on github, but they are minor. Please be aware of the patch in 949941. That should land to master soon, and may cause minor merge conflicts with this patch.
Attachment #8385832 - Flags: review?(dflanagan) → review+
Landed on camera-new-features: https://github.com/mozilla-b2g/gaia/commit/ce8e2cc83b6db75e6cd30d556905815a4a90baa9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Bulk edit for camera bugs. If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master. This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
status-b2g-v1.4: --- → fixed
status-b2g-v2.0: --- → fixed
Target Milestone: 1.4 S3 (14mar) → 1.4 S5 (11apr)
The bug is no longer reproduces on 1.4 and 1.5 master builds. Visual design is redesigned for Image Capture/Video buttons 1.4 Environmental Variables: Device: Buri 1.4 MOZ BuildID: 20140410000201 Gaia: 9b2da43dfee3792cd311ae55f0b06272313208f0 Gecko: 9d9ead7d6afa Version: 30.0a2 Firmware Version: v1.2-device.cfg 1.5 Environmental Variables: Device: Buri 1.5 MOZ BuildID: 20140410040201 Gaia: 9d0b1bdf746823a94b13e6574c1d8304dc584763 Gecko: 690c810c8e3e Version: 31.0a1 Firmware Version: v1.2-device.cfg
Status: RESOLVED → VERIFIED
status-b2g-v1.4: fixed → verified
status-b2g-v2.0: fixed → verified
You need to log in before you can comment on or make changes to this bug.