Closed Bug 971101 Opened 10 years ago Closed 10 years ago

build and publish geckoview example by default

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 31

People

(Reporter: blassey, Assigned: blassey)

References

Details

Attachments

(1 file, 2 obsolete files)

build_publish_example.patch
2.65 KB, patch
khuey
: review+
Details | Diff | Splinter Review
Attached patch build_publish_example.patch (obsolete) — — Splinter Review 
      No description provided.
Attachment #8374233 - Flags: review?(khuey)
Attached patch build_publish_example.patch (obsolete) — — Splinter Review 
try push https://tbpl.mozilla.org/?tree=Try&rev=524d7ff82fed
Assignee: nobody → blassey.bugs
Attachment #8374233 - Attachment is obsolete: true
Attachment #8374233 - Flags: review?(khuey)
Attachment #8374373 - Flags: review?(khuey)
Comment on attachment 8374373 [details] [diff] [review]
build_publish_example.patch

Clearly this fails on the try machines because ant isn't installed. So moving from review? to feedback?
Attachment #8374373 - Flags: review?(khuey) → feedback?(khuey)
Depends on: 971841
Comment on attachment 8374373 [details] [diff] [review]
build_publish_example.patch

Sorry for the churn, we're getting ant installed on builders. So, back to r?
Attachment #8374373 - Flags: feedback?(khuey) → review?(khuey)
updated to apply
Attachment #8374373 - Attachment is obsolete: true
Attachment #8374373 - Flags: review?(khuey)
Attachment #8382431 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/9e0b50571a10
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
I'm getting |Error: Project folder '/home/master/mozilla-central-droid/embedding/android/geckoview_example' is not empty. Please consider using 'android update' instead| now on my local build ...

All my tools/platforms/build-tools are current ... mozconfig using android-ndk-r8e and platforms/android-16

Local backout of this patch got me back in business
Ah - I see bug 991017 just got filed - looks like my issue
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.