Closed Bug 971120 Opened 10 years ago Closed 10 years ago

The help subview make the menu panel shrink

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 30
Tracking Flags:
Tracking Status
firefox29 --- verified
firefox30 --- verified

People

(Reporter: u428464, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P3-][good first verify])

Attachments

(1 file)

help view should be using panel-subview-body, too.
1.33 KB, patch
jaws
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
At least on Windows clicking the help button make the panel shrink a bit at the bottom.
Blocks: australis-cust
Whiteboard: [Australis:P3]
I'm tempted to mark this P4 or P5 considering how hard it is to even notice this.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [Australis:P3] → [Australis:P3-]
Well, it's kind of noticeable, because it creates two distinct steps on the transition (sometimes…). On the other hand the Help menu probably isn't getting as much traffic as some other subviews.
Looks like we missed this.
Attachment #8374354 - Flags: review?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #8374354 - Flags: review?(jaws) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/9659dca84dff
Whiteboard: [Australis:P3-] → [Australis:P3-][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9659dca84dff
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3-][fixed-in-fx-team] → [Australis:P3-]
Target Milestone: --- → Firefox 30
Comment on attachment 8374354 [details] [diff] [review]
help view should be using panel-subview-body, too.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: main panel behaves oddly when clicking help
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none
Attachment #8374354 - Flags: approval-mozilla-aurora?
Attachment #8374354 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [Australis:P3-] → [Australis:P3-][good first verify]
Fixed in 30b3.
Status: RESOLVED → VERIFIED
I can also confirm that this is verified.
status-firefox29: fixed → verified
status-firefox30: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: