971139 - make sure we don't leak memory when scanning album art

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[David Flanagan [:djf]]

In bug 963917 I fixed a memory leak in the Gallery app that occured only when scanning new media.  It affects any app that uses mediadb and includes blobs in the returned metadata objects. For Gallery, these blobs were image thumbnails.  It might also affect the music and video apps, so I'm bringing it up here.

Normally, when a media app starts, metadata is read from mediadb, and any blobs in the metadata records refer to files, so they don't take up much memory.  But in the scanning case, mediadb is writing metadata records to the db, but then passing those records to the app.  In this case, any blobs in the records are typically memory-backed blobs rather than file-backed blobs, and they will be expensive if you hold on to them for the lifetime of the app.

For gallery, I fixed this by explicitly looking up the metadata record for each newly scanned file instead of using the record that mediadb passed to me.

This bug is filed to check whether the Music app has the same leak and fix it, if so.

Comment 1

[Jim Porter (:squib)]

It'd probably be best to look at this after I land my changes for ID3 tags, since that has some pretty significant changes in how we handle album art.

Comment 2

[Jim Porter (:squib)]

With my ID3 changes, I think we're good here. Blobs (including thumbnails) should all be file-backed.