971186 - Hover state on tabs in .devtools-sidebar-tabs doesn't work properly

Status: VERIFIED FIXED

Description

[Victor Porof [:vporof][:vp]]

Open inspector. Hover the tabs in the sidebar. Not all tabs are highlighted when you hover them, only the immediate adjacent tab to the currently selected one.

Comment 1

[Girish Sharma [:Optimizer]]

(doesn't happen in latest nightly, but only in fx-team tip)

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Victor Porof [:vporof][:vp] from comment #0)
> Open inspector. Hover the tabs in the sidebar. Not all tabs are highlighted
> when you hover them, only the immediate adjacent tab to the currently
> selected one.

Note: this is dark theme only, and likely caused by Bug 969429.

Comment 3

[Brian Grinstead [:bgrins]]

Created attachment 8374360 [details] [diff] [review]
dark-theme-sidebar-hover.patch

Doh!  Missed a rule in the last patch

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8374360 [details] [diff] [review]
dark-theme-sidebar-hover.patch

Review of attachment 8374360 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Assuming it works.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d63309171ef0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d63309171ef0

Comment 7

[Tracy Walker [:tracy]]

Verified with latest build of Nightly