971208 - Vanilla new in ARMAssembler.o

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

/builds/slave/try_lx-d_sm-arm-sim-0000000000/objdir/js/_virtualenv/bin/python /builds/slave/try_lx-d_sm-arm-sim-0000000000/src/config/check_vanilla_allocations.py libjs_static.a
TEST-UNEXPECTED-FAIL | check_vanilla_allocations.py | 'operator new(unsigned' present at SegmentedVector.h:152

This is getting compiled into ARMAssembler.o.

Comment 1

[Steve Fink [:sfink] [:s:]]

Note that you normally don't see this on tbpl because ARM cross-compiles do not run 'make check'. A split-out test job could run this check and the rest (this check runs nm on libjs_static.a, so it has cross-compilation issues too). But they'll at least start to get run once bug 965447 lands.

Comment 2

[Steve Fink [:sfink] [:s:]]

njn, do you know how to fix this? If it were a vanilla malloc(), I'd probably try #define malloc js_malloc or something. But this is operator new(), and I'm not sure I want to just override it.

Comment 3

[Nicholas Nethercote [inactive]]

Just change it to use js_new... modifying that file isn't a problem, right?

Comment 4

[Steve Fink [:sfink] [:s:]]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> Just change it to use js_new... modifying that file isn't a problem, right?

I do believe you are correct. I thought it might be a hands-off imported file, but it already uses js::Vector, so apparently not. Thanks!

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Eliminate vanilla new in SegmentedVector.h

Looks like this built and is running on my test push now. Thanks!

Comment 6

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df02f131ca15

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df02f131ca15