Closed Bug 971208 Opened 8 years ago Closed 8 years ago

Vanilla new in ARMAssembler.o

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

/builds/slave/try_lx-d_sm-arm-sim-0000000000/objdir/js/_virtualenv/bin/python /builds/slave/try_lx-d_sm-arm-sim-0000000000/src/config/check_vanilla_allocations.py libjs_static.a
TEST-UNEXPECTED-FAIL | check_vanilla_allocations.py | 'operator new(unsigned' present at SegmentedVector.h:152

This is getting compiled into ARMAssembler.o.
Blocks: 965447
Note that you normally don't see this on tbpl because ARM cross-compiles do not run 'make check'. A split-out test job could run this check and the rest (this check runs nm on libjs_static.a, so it has cross-compilation issues too). But they'll at least start to get run once bug 965447 lands.
njn, do you know how to fix this? If it were a vanilla malloc(), I'd probably try #define malloc js_malloc or something. But this is operator new(), and I'm not sure I want to just override it.
Flags: needinfo?(n.nethercote)
Just change it to use js_new... modifying that file isn't a problem, right?
Flags: needinfo?(n.nethercote)
(In reply to Nicholas Nethercote [:njn] from comment #3)
> Just change it to use js_new... modifying that file isn't a problem, right?

I do believe you are correct. I thought it might be a hands-off imported file, but it already uses js::Vector, so apparently not. Thanks!
Looks like this built and is running on my test push now. Thanks!
Attachment #8374444 - Flags: review?(mrosenberg)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Attachment #8374444 - Flags: review?(mrosenberg) → review+
https://hg.mozilla.org/mozilla-central/rev/df02f131ca15
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 1001569
You need to log in before you can comment on or make changes to this bug.