971224 - Better log messages to troubleshoot failures of launching the service command

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Comment 1

[Masatoshi Kimura [:emk]]

FYI we already have a race between the elevated and unelevated updater. Here is first three lines from an update log (**** is my masked user name):
> Performing a background update
> calling QuitProgressUI
> s\****\AppData\Local\Mozilla\updates\E7CF176E110C211B\updates\0
> DESTINATION DIRECTORY C:\Program Files (x86)\Mozilla Firefox\updated

IIUC it should have been:
> Performing a background update
> SOURCE DIRECTORY C:\Users\****\AppData\Local\Mozilla\updates\E7CF176E110C211B\updates\0
> DESTINATION DIRECTORY C:\Program Files (x86)\Mozilla Firefox\updated

But the unelevated updater has overwritten the log in WaitForServiceFinishThread. Am I correct?

Comment 2

[Robert Strong (they/them - no direct email)]

Yes. It would be good to fix that one that slipped through at the same time.

Comment 3

[Masatoshi Kimura [:emk]]

Try run with the log patch: https://tbpl.mozilla.org/?tree=Try&rev=b02282d97cb5
An example of failed logs: https://tbpl.mozilla.org/php/getParsedLog.php?id=34534217&tree=Try&full=1
Indeed xpcshell tests fail, but "The post update process which runs as the user for service update could not be launched." is always displayed for succeeded non-staged updates. Is this failure expected?

Comment 4

[Robert Strong (they/them - no direct email)]

That isn't a failure for the tests. The tests don't launch the post update process intentionally.

Comment 5

[Robert Strong (they/them - no direct email)]

This was fixed awhile back so resolving as wfm