971255 - [AccessFu] Make it easier to run code conditional on debug log level

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: [AccessFu] Introduce Logger.doIfDebug

Why is this better than a simple if statement? Not sure.. maybe I like it becuase it encapsulates the logLevel a bit further..

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8374424 [details] [diff] [review]
[AccessFu] Introduce Logger.doIfDebug

Review of attachment 8374424 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good, but since we always call Logger.debug inside Logger.doIfDebug, lets make Logger.debug do the check internally. We won't need doIfDebug at all in that case.

Comment 3

[Eitan Isaacson [:eeejay]]

We already check the loglevel in debug(), the reason we still need to do it conditionally is because we making the strings to log is often not trivial, like accessibleToString, or other operations that we are only interested in performing when we are debugging, but not in production code.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: [AccessFu] Allow providing a callable argument to Logger log calls.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8375067 [details] [diff] [review]
[AccessFu] Allow providing a callable argument to Logger log calls.

Review of attachment 8375067 [details] [diff] [review]:
-----------------------------------------------------------------

awesome r=me with 1 nit.

::: accessible/src/jsat/Utils.jsm
@@ +352,5 @@
>        return;
>  
> +    let args = Array.prototype.slice.call(arguments, 1);
> +    let message = typeof(args[0]) === 'function' ?
> +      args[0]().join(' ') : args.join(' ');

Nit: 
let message = (typeof(args[0]) === 'function' ? args[0]() : args[0]).join(' ');

Comment 6

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e33d25de087

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9e33d25de087