971264 - Remove nsHashtable

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

It is deprecated.

Comment 1

[Andrew McCreight [:mccr8]]

All dependencies filed.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Remove nsHashtable.

Only three uses remain.  One is waiting for the tree to open, one is
waiting for a try run to finish, the third there just are some review
comments to address.  This is a patch on top of those patches.

Comment 3

[Andrew McCreight [:mccr8]]

(According to MXR, comm-central does not use nsHashtable or nsObjectHashtable.)

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8420177 [details] [diff] [review]
Remove nsHashtable.

This is just waiting on the patch in bug 984123 getting reviewed and landed.

(The header removals are things I forgot in various conversions.)

Comment 5

[Andrew McCreight [:mccr8]]

The last blocking patch is on inbound, but I'm not going to land this earlier than Friday in case there are some regressions from the last few patches that have landed.

Comment 6

[Benjamin Smedberg]

Comment on attachment 8420177 [details] [diff] [review]
Remove nsHashtable.

<3

Comment 7

[Andrew McCreight [:mccr8]]

Thanks to Anuj Agarwal for fixing a bunch of the dependencies here!

https://hg.mozilla.org/integration/mozilla-inbound/rev/f48eaa689a9f

Comment 8

[Andrew McCreight [:mccr8]]

Also thanks to the many reviewers who had to dig through dusty old code to make sure I didn't break things too badly in my patches. ;)

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f48eaa689a9f

Comment 10

[Andrew McCreight [:mccr8]]

I removed the very brief mention of them from the XPCOM hashtable guide.

Comment 11

[Andrew McCreight [:mccr8]]

In fact, every one of the deprecated hash tables in that guide is gone now, so I removed the whole section!

https://developer.mozilla.org/en-US/docs/Detailed_XPCOM_hashtable_guide