[Windows] Tabs do not extend to the top edge of the screen while maximized

RESOLVED INVALID

Status

()

Firefox
Theme
RESOLVED INVALID
4 years ago
4 years ago

People

(Reporter: Lozzy, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P3])

(Reporter)

Description

4 years ago
Specifically, when Firefox is initially loaded in a maximised state. So Firefox must have been closed in a maximised state to trigger this. Before Australis, the edges of tabs would extend up to the top of the screen so they would be easier targets.

Fortunately, you can simply restore the window down and maximise it again to get the tab edges back up the top. But this shouldn't be necessary and could degrade the experience for people who always run in maximised mode.
Mike, do you think this is a regression from the recent changes to tabsintitlebar?

"Lozzy", in what build are you seeing this? Nightly? Aurora? What version? Was it always broken?
Blocks: 872617
Component: Tabbed Browser → Theme
Flags: needinfo?(mconley)
Flags: needinfo?(laurencedurant1)
Whiteboard: [Australis:P3]
(In reply to :Gijs Kruitbosch from comment #1)
> Mike, do you think this is a regression from the recent changes to
> tabsintitlebar?
> 
> "Lozzy", in what build are you seeing this? Nightly? Aurora? What version?
> Was it always broken?

I don't believe any of that stuff should have affected Windows, but we could have made a mistake.

Yes, knowing which channel the user is experiencing this on would be a good start.

"Lozzy", are you comfortable trying to help us narrow down the regression range, and find out when this bug got introduced?
Flags: needinfo?(mconley)
(Reporter)

Comment 3

4 years ago
I'm on Aurora channel, so this got pushed to me when the channels shifted a few days ago.

I can help with narrowing the range. I've heard there's a script/tool for that, but I've never tried it.
Flags: needinfo?(laurencedurant1)
Yes, there's a tool for that called mozregression:

https://github.com/mozilla/mozregression

Let us know if you need any assistance in its use.
Blocks: 732583
No longer blocks: 872617
Summary: Tabs do not extend to edge after Australis → [Windows] Tabs do not extend to the top edge of the screen while maximized
(Reporter)

Comment 5

4 years ago
Ok, I have the rough output from mozregression;

Got as far as we can go bisecting nightlies...
Ensuring we have enough metadata to get a pushlog...
Last good revision: beddd6d4bcdf (2013-11-18)
First bad revision: ba9ecdea3a90 (2013-11-19)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=beddd6d4bcdf&tochan
ge=ba9ecdea3a90

After that it couldn't complete the fine grained tests; it told me "No builds available for 64 bit Windows (try specifying --bits=32)". I had to use bits=32 to get the previous results. I don't fancy writing a bug report for that I'm afraid!
(In reply to Lozzy from comment #5)
> Ok, I have the rough output from mozregression;

Thank you very much. That's the initial Australis landing so we'll need more information (or you could bisect the UX repo with: "-r ux" but I wouldn't be surprised if it's from some of the initial patches for this).

I suspect you have a configuration that is making an element taller than the default.
* Do you know what your DPI/text zoom setting on Windows is? Right click on the desktop > Screen Resolution > "Make text and other items larger or smaller". What is the selected percentage?
* Could you provide a screenshot of your tabs in the latest build when they aren't reaching the top like they should?
Flags: needinfo?(laurencedurant1)
(Reporter)

Comment 7

4 years ago
Sussed it! I narrowed it down to the Session Manager addon causing the problem. Disabling that fixed the issue.

Apologies for the false alarm, but it only seemed plausible that this could have come through the channel update. I shall email the addon developer and point them here to see if they can fix it. Would be interesting to see what the addon is changing to cause this.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(laurencedurant1)
Resolution: --- → INVALID
(Reporter)

Comment 8

4 years ago
More good news; the addon has been fixed in it's preview version. So hopefully the main version is updated before Australis gets to a larger audience.
You need to log in before you can comment on or make changes to this bug.