Closed
Bug 971357
Opened 10 years ago
Closed 9 years ago
Ensure that STUN traffic is logged to the RLogRingbuffer
Categories
(Core :: WebRTC: Networking, defect, P4)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
backlog | webrtc/webaudio+ |
People
(Reporter: bwc, Assigned: bwc)
Details
Attachments
(1 file, 3 obsolete files)
Right now, STUN traffic is logged at DEBUG, but setting the log level to DEBUG causes the RLogRingbuffer to be rapidly overwritten by media traffic logging.
Assignee | ||
Updated•10 years ago
|
QA Contact: docfaraday
Assignee | ||
Comment 1•10 years ago
|
||
It may be good enough just to log that we've received a STUN response. We probably also want to throttle down the media packet logging.
Assignee | ||
Comment 2•10 years ago
|
||
One possible fix.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → docfaraday
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Attachment #8374560 -
Flags: review?(ekr)
Assignee | ||
Comment 3•10 years ago
|
||
Unrot and improve.
Assignee | ||
Updated•10 years ago
|
Attachment #8374560 -
Attachment is obsolete: true
Attachment #8374560 -
Flags: review?(ekr)
Assignee | ||
Updated•10 years ago
|
Attachment #8438064 -
Flags: review?(ekr)
Comment 4•9 years ago
|
||
Byron -- Can you unrot and revector this to Nils when you are both back from PTO?
backlog: --- → webRTC+
Rank: 45
Flags: needinfo?(docfaraday)
Priority: -- → P4
Comment 5•9 years ago
|
||
Comment on attachment 8438064 [details] [diff] [review] Log STUN responses at INFO instead of DEBUG. Review of attachment 8438064 [details] [diff] [review]: ----------------------------------------------------------------- Clearing review flag. Byron, please feel free to re-r? and I will review.
Attachment #8438064 -
Flags: review?(ekr)
Assignee | ||
Comment 6•9 years ago
|
||
Unrot.
Assignee | ||
Updated•9 years ago
|
Attachment #8438064 -
Attachment is obsolete: true
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8627732 [details] [diff] [review] Log STUN responses at INFO instead of DEBUG Review of attachment 8627732 [details] [diff] [review]: ----------------------------------------------------------------- https://treeherder.mozilla.org/#/jobs?repo=try&revision=0635073f2c29
Attachment #8627732 -
Flags: review?(ekr)
Comment 8•9 years ago
|
||
Byron, could you put this on reviewboard?
Assignee | ||
Comment 9•9 years ago
|
||
Bug 971357: Log STUN responses at INFO instead of DEBUG.
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8627734 [details] MozReview Request: Bug 971357: Log STUN responses at INFO instead of DEBUG. Bug 971357: Log STUN responses at INFO instead of DEBUG.
Attachment #8627734 -
Flags: review?(ekr)
Assignee | ||
Updated•9 years ago
|
Attachment #8627732 -
Attachment is obsolete: true
Flags: needinfo?(docfaraday)
Attachment #8627732 -
Flags: review?(ekr)
Comment 11•9 years ago
|
||
https://reviewboard.mozilla.org/r/12265/#review10767 ::: media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c:457 (Diff revision 1) > - r_log(NR_LOG_STUN,LOG_DEBUG,"STUN-CLIENT(%s): Received check response (my_addr=%s,peer_addr=%s)",ctx->label,ctx->my_addr.as_string,peer_addr->as_string); > + r_log(NR_LOG_STUN,LOG_DEBUG,"STUN-CLIENT(%s): Inspecting STUN response (my_addr=%s,peer_addr=%s)",ctx->label,ctx->my_addr.as_string,peer_addr->as_string); Suggest a comma between addresses here. ::: media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c:739 (Diff revision 1) > + r_log(NR_LOG_STUN,LOG_WARNING,"STUN-CLIENT(%s): Error %d processing response, stun error code %d.", ctx->label, _status, (int)ctx->error_code); Use nr_strerror() to translate \_status?
Comment 12•9 years ago
|
||
r=me with or without these changes.
Updated•9 years ago
|
Attachment #8627734 -
Flags: review?(ekr) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8627734 -
Flags: review+ → review?(ekr)
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8627734 [details] MozReview Request: Bug 971357: Log STUN responses at INFO instead of DEBUG. Bug 971357: Log STUN responses at INFO instead of DEBUG.
Assignee | ||
Comment 14•9 years ago
|
||
https://reviewboard.mozilla.org/r/12265/#review10767 > Suggest a comma between addresses here. I'm going to guess you meant whitespace, since there's already a comma.
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8627734 [details] MozReview Request: Bug 971357: Log STUN responses at INFO instead of DEBUG. Carry forward r=ekr
Attachment #8627734 -
Flags: review?(ekr) → review+
Comment 16•9 years ago
|
||
https://reviewboard.mozilla.org/r/12265/#review10893 I don't know why this won't let me mark it ship it, but LGTM
Comment 18•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/740bf479671a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•