Closed Bug 97140 Opened 23 years ago Closed 23 years ago

Table property dialog will not dismiss

Categories

(Core :: DOM: Editor, defect, P2)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.4

People

(Reporter: rubydoo123, Assigned: cmanske)

References

Details

Attachments

(2 files)

Fix
1.38 KB, patch
Details | Diff | Splinter Review
Updated fix
1.38 KB, patch
Details | Diff | Splinter Review 
In today's build (2001082703) on win98, the table dialog will not dismiss after 
making changes.
Severity: normal → major
Priority: -- → P2
how to reproduce:
1. open composer with a document that contains a table
2. set focus in a table cell
3. select table cell properties
4. change any property value
5. select OK, the dialog does not dismiss
   select Apply, the change does not take affect
   select cancel, the dialog dismisses without the change

the only way to get the change to take affect is to select the next cell then 
select the close option (x) in the upper right corner.
Uggg! Sorry, caused this with fix to bug 96649.
Status: NEW → ASSIGNED
Keywords: regression
Target Milestone: --- → mozilla0.9.4
Attached patch Fix — — Splinter Review 

    
    

    
  
Simple fix. Return false only if user cancels from the warning dialog.
If we don't fix this, this dialog is unusable! (Sorry again).
Keywords: patch, 
          
            review
Whiteboard: FIX IN HAND need r=, sr=

    
    

    
  
r=brade (assuming tests I suggested are fine and formatting changes are made)

Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND need sr=

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updated fix
        — 
          — Splinter Review
      

    


  

    
    

    
  
*** Bug 97051 has been marked as a duplicate of this bug. ***

    
    

    
  
sr=kin@netscape.com with brade's provisions.
Whiteboard: FIX IN HAND need sr= → FIX IN HAND, reviewed

    
    

    
  
a=asa on behalf of drivers.

    
    

    
  
*** Bug 97242 has been marked as a duplicate of this bug. ***

    
    

    
  
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: patch, 
          
            regression, 
          
            review
Resolution: --- → FIXED
Whiteboard: FIX IN HAND, reviewed

    
    

    
  
*** Bug 97482 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 97489 has been marked as a duplicate of this bug. ***

    
    

    
  
verified.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: