971438 - reenable make test-perf for costcontrol

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P1)

Description

[Hubert Figuiere [:hub]]

During bug 915156 we disabled the test for costcontrol as it was causing issues.

We should reenable it.

The problem is mostly that it hangs marionette indefinitely if there is no SIM card.

Comment 1

[Hubert Figuiere [:hub]]

We need to unblock.

Comment 2

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20591

Since Eli is on PTO, can you review this trivial change?

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8441124 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20591

r=me

it doesn't seem to hang now, but it's probably still incorrect though.

Comment 4

[Hubert Figuiere [:hub]]

The costcontrol team is adding testing to the app so things should get better and testing get relevant.

Thanks

Comment 5

[Hubert Figuiere [:hub]]

Merged in master
https://github.com/mozilla-b2g/gaia/commit/f278ddc0d2e992dc6a2a8686ced494e0aa0f689b

Comment 6

[Hubert Figuiere [:hub]]

Comment on attachment 8441124 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20591

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): not a regression
[User impact] if declined: Prevent further perf testing for cost control app (see blocking bugs)
[Testing completed]: testing with Ci (Gaia Try) and device.
[Risk to taking this patch] (and alternatives if risky): very low. NPOTB (test only).
[String changes made]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/6d1555eb582e4a1a8ec3f57668506db89869e58e