971458 - [System2] Instantiable AppWindowFactory

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need app_window_factory.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 16607

Another one needs to be reviewed.

Alive, thank you very much for your help!

Comment 2

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/19965063

merged in gaia bubble-tea:
https://github.com/mozilla-b2g/gaia/commit/c871bc55bead5902c618dd44dee60ef87849ed61


Alive, Thanks!

Comment 3

[[e-mail]]

Attachment: master PR#17633

Comment 4

[[e-mail]]

luke, Though we plan to merge bubble-tea to master in order.
Due to test fail occurred in this patch, please help create a PR, check travis is green and land it to master. Thanks.

Comment 5

[Luke Chang [:lchang] (inactive)]

OK, I'm looking into it.

Comment 6

[Luke Chang [:lchang] (inactive)]

Attachment: pull request to master branch

Comment 7

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/21645237

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/32efafab4da5e29a9b9abee50f82adecd86ebce5