971459 - [System2] Instantiable Applications

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need applications.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/16660

Hi Alive,
   This is my version 1 patch, I've completed major task such as:
   - Instantiable applications.js
   - add JSdocs
   - fix JShint

   ToDo:
   add applications_test

   please give me some feedback thanks.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8382081 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/16660

Please make sure everything goes well because this is an important module.

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8382081 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/16660

Hi Alive,
   I've addressed your comment and added unit test for applications.js.

   Please help to review second run, thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8382081 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/16660

All python tests are failed. Please fix gaia_apps.js to replace Applications with applications.

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/16779

Hi Alive,
   Please review again.
   Travis got green.
   https://travis-ci.org/mozilla-b2g/gaia/builds/19957217

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8384483 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/16779

Thanks!

Comment 7

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Thanks Alive,
landed in bubble-tea

Comment 8

[[e-mail]]

Attachment: master PR#17633

Comment 9

[[e-mail]]

sorry attach is a wrong one

Comment 10

[[e-mail]]

gary, Though we plan to merge bubble-tea to master in order,
due to merge conflict occurred in this patch, please help create a PR, check travis is green and land it to master. Thanks.

Comment 11

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

:gasolin, thanks,
I have a PB waiting for Travis green.

Comment 12

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

(In reply to GaryChen [:GaryChen][:PYChen][:陳柏宇] from comment #11)
> :gasolin, thanks,
> I have a PB waiting for Travis green.

s/PB/PR

Comment 13

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

https://github.com/mozilla-b2g/gaia/pull/17639

Comment 14

[[e-mail]]

travis green, merged https://github.com/mozilla-b2g/gaia/commit/72c2930b3e0528dc9e201087888b75714c8f3427

thanks!

Comment 15

[Kevin Grandon :kgrandon]

Follow-up to fix the linter: https://github.com/mozilla-b2g/gaia/commit/bd7084cb4069e5d0555fbaa0f80535628d978d57

Looks like this crossed with another commit on its way to land.