Closed Bug 971469 Opened 7 years ago Closed 7 years ago

[System2] Instantiable BatteryManager

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S6 (10oct)

People

(Reporter: alive, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
We need battery_manager.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
I'll take this.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Attached file Github pull request
Comment on attachment 8500145 [details] [review]
Github pull request

Hey Alive - Please take a look if you can.

We can not assign BatteryManager as a constructor as it is already on the window object: https://developer.mozilla.org/en-US/docs/Web/API/BatteryManager

Because of this, the patch renames BatteryManager to BatteryOverlay.
Attachment #8500145 - Flags: review?(alive)
Comment on attachment 8500145 [details] [review]
Github pull request

nice one
Attachment #8500145 - Flags: review?(alive) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/b0e9fd9ffa8d7a727c1976365f0ff0262eabfb1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in before you can comment on or make changes to this bug.