Closed
Bug 971469
Opened 11 years ago
Closed 10 years ago
[System2] Instantiable BatteryManager
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: alive, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
We need battery_manager.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
|
Assignee | |
Comment 1•10 years ago
|
||
I'll take this.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8500145 [details] [review]
Github pull request
Hey Alive - Please take a look if you can.
We can not assign BatteryManager as a constructor as it is already on the window object: https://developer.mozilla.org/en-US/docs/Web/API/BatteryManager
Because of this, the patch renames BatteryManager to BatteryOverlay.
Attachment #8500145 -
Flags: review?(alive)
|
Reporter | |
Comment 4•10 years ago
|
||
Comment on attachment 8500145 [details] [review]
Github pull request
nice one
Attachment #8500145 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•