Closed Bug 971479 Opened 8 years ago Closed 7 years ago

[System2] Instantiable CellBroadcastSystem

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 wontfix, b2g-v2.2 fixed)

RESOLVED FIXED
2.1 S5 (26sep)
Tracking Status
b2g-v2.1 --- wontfix
b2g-v2.2 --- fixed

People

(Reporter: alive, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
We need cell_broadcast_system.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
I'll help out with some more instantiable v2 system now. Starting with a simple one.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Attached file Github pull request
Comment on attachment 8489834 [details] [review]
Github pull request

Alive - this will have a tiny merge conflict with your mobile connection subsystem patch. Sorry - I did this one before checking-in with you about what to work on :) If these conflicts will be a pain, I'm fine waiting to land this after your mobile sub-system work is done.

The conflict will likely be at: https://github.com/mozilla-b2g/gaia/pull/24076/files#diff-c5ad41a1641005ca1986003bbac34be7R71
Attachment #8489834 - Flags: review?(alive)
Comment on attachment 8489834 [details] [review]
Github pull request

It's not TTLView in the test
Attachment #8489834 - Flags: review?(alive) → review+
Updated pull request based on github commits. Let's resume the system v2 party.

In master: https://github.com/mozilla-b2g/gaia/commit/3181366be113fc618c98c5a47b695b3fb0d29a8e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in before you can comment on or make changes to this bug.