Closed
Bug 971479
Opened 12 years ago
Closed 11 years ago
[System2] Instantiable CellBroadcastSystem
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.1 wontfix, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: alive, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
We need cell_broadcast_system.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
|
Assignee | |
Comment 1•11 years ago
|
||
I'll help out with some more instantiable v2 system now. Starting with a simple one.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8489834 [details] [review]
Github pull request
Alive - this will have a tiny merge conflict with your mobile connection subsystem patch. Sorry - I did this one before checking-in with you about what to work on :) If these conflicts will be a pain, I'm fine waiting to land this after your mobile sub-system work is done.
The conflict will likely be at: https://github.com/mozilla-b2g/gaia/pull/24076/files#diff-c5ad41a1641005ca1986003bbac34be7R71
Attachment #8489834 -
Flags: review?(alive)
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 8489834 [details] [review]
Github pull request
It's not TTLView in the test
Attachment #8489834 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Updated pull request based on github commits. Let's resume the system v2 party.
In master: https://github.com/mozilla-b2g/gaia/commit/3181366be113fc618c98c5a47b695b3fb0d29a8e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•