Closed Bug 971483 Opened 10 years ago Closed 10 years ago

[System2] Instantiable DevToolsLayer

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: alive, Assigned: kgrandon)

References

Details

(Keywords: perf, Whiteboard: [c= p=3 s=2014.02.14 u=])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
We need devtools_layer.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
I'll help with some easy ones first, taking this.
Assignee: nobody → kgrandon
Keywords: perf
Whiteboard: [c= p=3 s= u=]
Attached file Github pull request — 

    
    

    
  
Comment on attachment 8374887 [details] [review]
Github pull request

Alive - another one for you. Few reviews coming your way, so feel free to redirect as necessary. Thanks!

        Attachment #8374887 -
        Flags: review?(alive)

    
    

    
  
Comment on attachment 8374887 [details] [review]
Github pull request

Nice rename

        Attachment #8374887 -
        Flags: review?(alive) → review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/a058f6c93cac01fbff1f62cdbe0fb1a8a50b533e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [c= p=3 s= u=] → [c= p=3 s=2014.02.14 u=]

    
    

    
  
Thanks for making it instantiable!

Nit: Your commit message mentions "DevToolsLayer", but you called the feature "DevtoolsView" in the code.

Please also explain why you renamed the feature. I was thinking of eventually renaming it to something closer to "Developer HUD".
Flags: needinfo?(kgrandon)

    
    

    
  
Sorry - should've looped you in. Renaming to DevtoolsHUD, or even just Devtools is probably fine. We renamed because we still have TTLView, and the naming should be consistent. If we get rid of that file, or integrate the two - feel free to update it. Thanks!
Flags: needinfo?(kgrandon)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: