Closed
Bug 971495
Opened 10 years ago
Closed 10 years ago
[System2] Instantiable HardwareButton
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: timdream)
References
Details
Attachments
(1 file)
We need hardware_button.js to be instantiable and let bootstrap or its parent module to instantiate it. Also jsdoc + unit test improvement wanted.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → timdream
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8376091 [details] [review] mozilla-b2g:master PR#16280 Alive, need your feedback on this. What I did: -- jshint -- convert HardwareButtons to a construction function -- convert all the states to construction functions -- create an instance (with XXX) at the bottom -- mark unresolved dependency (ScreenManager) with XXX -- fire() -> publish() -- explicit start() and stop() What to do: -- manual tests -- jsdoc -- unit tests
Attachment #8376091 -
Flags: feedback?(alive)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8376091 [details] [review] mozilla-b2g:master PR#16280 https://github.com/mozilla-b2g/gaia/pull/16280?w=1 will be more more helpful for reading.
Reporter | ||
Updated•10 years ago
|
Attachment #8376091 -
Flags: feedback?(alive) → feedback+
Reporter | ||
Comment 4•10 years ago
|
||
nit: We should separate HardwareButtonState and HardwareButtonStateManager to 2 files in the following. Highly recommended: Let HardwareButton(StateManager/StateMachine) to instantiate the states instead of instantiating every time the state is changed.
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8376091 [details] [review] mozilla-b2g:master PR#16280 Completed: -- jsdocs -- manual tests WIP: -- unit tests
Attachment #8376091 -
Flags: feedback?(alive)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8376091 [details] [review] mozilla-b2g:master PR#16280 ++
Attachment #8376091 -
Flags: feedback?(alive) → feedback+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8376091 [details] [review] mozilla-b2g:master PR#16280 Unit test added :)
Attachment #8376091 -
Flags: review?(alive)
Reporter | ||
Comment 8•10 years ago
|
||
Comment on attachment 8376091 [details] [review] mozilla-b2g:master PR#16280 Nice work, thanks!
Attachment #8376091 -
Flags: review?(alive) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Squashed and waiting for Travis.
Assignee | ||
Comment 10•10 years ago
|
||
Fixed, green, and landed: https://github.com/mozilla-b2g/gaia/commit/5b6e783573a1e03426f104b1460f1a47b4bc4052
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•