971496 - filesystem crashstorage doesn't clean up

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[K Lars Lohn [:lars] [:klohn]]

when the file system classes traverse the date directory tree and they find a symbolic link, but that symbolic link doesn't lead to valid crash files, it leaves the link in place. That prevents it from fully deleting the date branch.  It complains bitterly about this every time it encounters them, which makes for huge logs...

socorro/external/fs/crash_storage.py:597 ought to outdented one level. That ought to insure that the symbolic link is deleted no matter what.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

Attachment: PR for eliminating orphan link problem

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/bf5c27eaca2f1782c7bfaa9fc21a9c648201615d
Bug 971496 - stopped orphan links, enabled cleanup of existing orphan links

https://github.com/mozilla/socorro/commit/5251a6a0ec5b1af40928ae4a5788d0e191e4a6d3
Merge pull request #1876 from twobraids/fs-link-lock

Bug 971496 (v74) - stopped orphan links, enabled cleanup of existing orphan links