971498 - [System2] Instantiable HomescreenLauncher

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need homescreen_launcher.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: WIP pull request

Hi Alive,

I am halfway of refactoring HomescreenLauncher to be an instantiable one. I'd like to have your feedback if I am getting things right or not. Thanks


Things done:
1. Make HomescreenLauncher instantiable
2. Fix broken tests because of 1.
3. Run and pass jshint against homescreen_launcher.js


Things to do:
4. add jsdoc for HomescreenLauncher
5. improve unit tests of HomescreenLauncher

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8378833 [details] [review]
WIP pull request

See github commits.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

I made a new pull request based on previous one because this patch should go to bubble-tea for now.

Hi Alive,
Please kindly help to review the patch, Thanks

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8381851 [details]
pull request

r+ with nit

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

travis is green 
https://travis-ci.org/mozilla-b2g/gaia/builds/19700996

landed on bubble-tea 
https://github.com/mozilla-b2g/gaia/commit/5b4c4ee13c8b2b570574999c48cd6d77c01c9dff

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

two follow-ups: bug 976986 and bug 976998

Comment 7

[[e-mail]]

seems this fails TBPL, https://tbpl.mozilla.org/?tree=Try&rev=1d5983643117

please backout it

Comment 8

[[e-mail]]

Tzu-Lin, though we plan to merge bubble-tea to master in order.
Due to many conflict occurred in this patch, please help create a PR, check travis is green and land it to master. Thanks.

Comment 9

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: mozilla-b2g:master PR#17420 along with bug 979212

Comment 10

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Travis is green
https://travis-ci.org/mozilla-b2g/gaia/builds/21496703

Waiting for TBPL result
https://tbpl.mozilla.org/?tree=Try&rev=592976cc8819

Comment 11

[Tzu-Lin Huang [:dwi2][:tzhuang]]

landed on master
https://github.com/mozilla-b2g/gaia/commit/c544c37e9967c9d4ca84d1b1322ab72c12f5f382