Closed Bug 971506 Opened 10 years ago Closed 10 years ago

[System2] Instantiable InternetSharing

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S2 (23may)

People

(Reporter: alive, Assigned: kgrandon)

References

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(1 file, 1 obsolete file)

Github pull request
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
We need internet_sharing to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
This one seems pretty simple, I'll take it.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S2 (23may)
Attached file Github pull request (obsolete) — 

    
    

    
  
Comment on attachment 8420708 [details]
Github pull request

Hey Alive, please review when you have a chance. Thanks!

        Attachment #8420708 -
        Flags: review?(alive)

        Attachment #8420708 -
        Flags: review?(alive) → review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/d364c473012b7731688fe0ef4bca92358cee18c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
(In reply to Phil Ringnalda (:philor) from comment #5)
> Curiously, you seem to have broken gaia-unit:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=39886576&tree=B2g-Inbound

Sorry - I think we may have crossed with another patch before landing (travis was green). Will try to be more prompt about landing so this doesn't happen again.

Backed out: https://github.com/mozilla-b2g/gaia/commit/1b2fd189fa6ac2eeb0708c122bbef4c542db2b43
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached file
          
        Github pull request
        — 
      

    


  

        Attachment #8420708 -
        Attachment is obsolete: true

    
    

    
  
Verifying the new fix on gaia-try: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=6480e4777502

    
    

    
  
Comment on attachment 8424381 [details] [review]
Github pull request

I'm going to assume that the new green gaia-try means we're good. (This issue also cropped up on gaia-try for other pull requests after we landed in master: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=c1a9c8cc2f21). Carrying review.

        Attachment #8424381 -
        Flags: review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/e0c2d9365f151caf9a24c8a9c2f28da418f58f1f
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: