971520 - [System2] Instantiable NfcManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need nfc_manager.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

I would like to work on this once I'll finish the test cases for NfcManager. Please assign this to me.

Comment 2

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-971520.txt

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Comment on attachment 8472969 [details] [review]
pull-request-971520.txt

Hi Alive, could review this?

I'm currently doing self-initilization. I can move the regular initilization code to bootstrap.js or perform lazy loading and initialization of NfcManager when nfc.enabled setting is switched on for the first time. 

Could you suggest a solution? If we would go with lazy-loading, where should the code be placed?

Is it ok to land this and file a separate bug for the initialization?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8472969 [details] [review]
pull-request-971520.txt

Please instantiate a new NFC manager in unit test (in setup function) each time you need it.

The spirit of instantiable singleton is we have different copy and states in each new object. If you override window.NfcManager with new NfcManager then nothing is changed in this patch..

Comment 5

[Krzysztof Mioduszewski[:tauzen]]

Comment on attachment 8472969 [details] [review]
pull-request-971520.txt

Addressed the comments, and as discussed on IRC moved initialisation to bootstrap.js and modified tests accordingly.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8472969 [details] [review]
pull-request-971520.txt

r=me

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/9bc229db6db17b92bae8dc5e8d1160cba632ec52