Closed
Bug 971521
Opened 10 years ago
Closed 10 years ago
[System2] Instantiable NfcUtil
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S3 (29aug)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: alive, Assigned: dgarnerlee)
References
Details
Attachments
(1 file)
We need nfc_util.js to be instantiable and let bootstrap or its parent module to instantiate it. Also jsdoc + unit test improvement wanted.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dgarnerlee
|
|
Assignee | |
Comment 1•10 years ago
|
||
Is there a MDN specific style guide for JSDoc?
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8473095 [details] [review] Patch. Review Req. Two parts: NfcUtils refactor, and contacts app update to use the new feature. This does not change NfcManager itself to be instantiable.
Attachment #8473095 -
Flags: review?(alive)
Attachment #8473095 -
Flags: feedback?(mbudzynski)
|
Reporter | |
Updated•10 years ago
|
Attachment #8473095 -
Flags: review?(alive) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
Oops. Now added r=alive. No other change.
|
||
Comment 5•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/7baf861dddf21919bd5ea1e3923b6f176e260e3b
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8473095 -
Flags: feedback?(mbudzynski)
You need to log in
before you can comment on or make changes to this bug.
Description
•