Closed Bug 971539 Opened 9 years ago Closed 8 years ago

[System2] Instantiable Place

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)

People

(Reporter: alive, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe],[p=2])

Attachments

(1 file, 1 obsolete file)

Github pull request
50 bytes, text/plain
daleharvey
: review+
alive
: review+
Details 
We need place.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
Attached file Github pull request (obsolete) —
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Github pull request —
Attachment #8413249 - Attachment is obsolete: true
Whiteboard: [systemsfe]
Whiteboard: [systemsfe] → [systemsfe],[p=2]
Target Milestone: --- → 2.0 S1 (9may)
Comment on attachment 8413250 [details]
Github pull request

Dale or Alive - could either of you guys review this one? Thanks!
Attachment #8413250 - Flags: review?(dale)
Attachment #8413250 - Flags: review?(alive)
Comment on attachment 8413250 [details]
Github pull request

Theres a nit with a tab introduced, and the commit message needs fixed, the rest looks good.

Thanks for cleaning up some of the technical debt, we can introduce more unit testing as we need to start using a new datastore api, https://bugzilla.mozilla.org/show_bug.cgi?id=1003601

I would like alive to give this a check since theres no rush
Attachment #8413250 - Flags: review?(dale) → review+
Comment on attachment 8413250 [details]
Github pull request

r+ but I believe we don't need AppWindowManager dependency. See my comments.
Also I expect we have place_test but could be followup.
Attachment #8413250 - Flags: review?(alive) → review+
Landed for now without the changes to requestScreenshot due to the rocketbar integration. We can fix this in a follow-up if desired.

https://github.com/mozilla-b2g/gaia/commit/383064550fe24316269d40f1b68a31c46f684ee3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.