Closed
Bug 971552
Opened 12 years ago
Closed 11 years ago
[System2] Instantiable SleepMenu
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S3 (6june)
People
(Reporter: alive, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 file, 1 obsolete file)
We need sleep_menu.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
|
Assignee | |
Comment 1•11 years ago
|
||
I'll take this one for something to do over a plane ride.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8424457 [details]
Github pull request
Hey Alive - although slower, I'm still doing these. Sorry you don't get a break from me :)
Attachment #8424457 -
Flags: review?(alive)
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 8424457 [details]
Github pull request
Thanks!
Attachment #8424457 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
|
|
||
Comment 6•11 years ago
|
||
sorry had to revert this change kevin, seems this caused https://tbpl.mozilla.org/php/getParsedLog.php?id=40451682&tree=B2g-Inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•11 years ago
|
||
Thanks for the revert and sorry about that! Will check try before next push.
|
|
Assignee | |
Comment 9•11 years ago
|
||
Try was green this time, so relanding: https://github.com/mozilla-b2g/gaia/commit/fa97404a6eae836263c11584b29dafdc5b54091d
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•