Closed
Bug 971553
Opened 10 years ago
Closed 10 years ago
[System2] Instantiable SoftwareButtonManager
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: kgrandon)
References
Details
(Keywords: perf, Whiteboard: [c= p=2 s= u=])
Attachments
(1 file)
We need software_button_manager.js to be instantiable and let bootstrap or its parent module to instantiate it. Also jsdoc + unit test improvement wanted.
|
Assignee | |
Comment 1•10 years ago
|
||
Taking.
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8388239 [details] [review] Github pull request Hey Alive - got time for this review? Also what do you think about the object access in layout_manager.js. Is there a better/cleaner way of doing that?
Attachment #8388239 -
Flags: review?(alive)
|
Reporter | |
Comment 4•10 years ago
|
||
Comment on attachment 8388239 [details] [review] Github pull request Could you try turn on software home button from developer settings to manual test for a while? r+ if manually tested.
Attachment #8388239 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!][:艾莉芙] from comment #4) > Comment on attachment 8388239 [details] [review] > Github pull request > > Could you try turn on software home button from developer settings to manual > test for a while? r+ if manually tested. Yup - I manually test *all* of my patches, so we should be good to go here. Thanks!
|
|
Assignee | |
Comment 6•10 years ago
|
||
Though I do think I will wait for the 1.4 cutover date before landing this and some of the other ones. I don't think there's a ton of value getting these resolved so late in the 1.4 cycle.
|
|
Assignee | |
Comment 7•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/5e89c55e77eb7b5d29f7cca13a114e3b74ecdd30
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•