Closed
Bug 971564
Opened 10 years ago
Closed 10 years ago
[System2] Instantiable TelephonySettings
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: kgrandon)
References
Details
(Keywords: perf, Whiteboard: [c= p=2 s=2014.03.14 u=])
Attachments
(1 file, 1 obsolete file)
We need telephony_settings.js to be instantiable and let bootstrap or its parent module to instantiate it. Also jsdoc + unit test improvement wanted.
|
Assignee | |
Comment 1•10 years ago
|
||
I'll take this small one - but will spend a bunch of time adding tests.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Hey Alive - Wondering if you could give this a quick review. I've added a lot of tests for this file (previously were none), but it's still always scary changing un-tested stuff like this. I'm pretty sure this is rock-solid though, so if it looks good to you, I'd like to land this in master whenever the R+ comes. Thanks!
Attachment #8386521 -
Attachment is obsolete: true
Attachment #8386912 -
Flags: review?(alive)
|
Reporter | |
Updated•10 years ago
|
Attachment #8386912 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks for the review! Landed in master: https://github.com/mozilla-b2g/gaia/commit/6c109df47006b08c082761c0ddd6ba53a864983a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [c= p=2 s= u=] → [c= p=2 s=2014.03.14 u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•