Closed
Bug 971565
Opened 10 years ago
Closed 10 years ago
[System2] Instantiable Title
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: eragonj)
References
Details
Attachments
(1 file)
We need title.js to be instantiable and let bootstrap or its parent module to instantiate it. Also jsdoc + unit test improvement wanted.
Assignee | ||
Comment 1•10 years ago
|
||
Just want to know more about System and took this easy one as a good start :P
Assignee: nobody → ejchen
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8376129 [details] [review] patch Hi Alive, can you help me review this part when you have time :) ? This change just got green from Travis (https://travis-ci.org/mozilla-b2g/gaia/builds/19012997) Big thanks !!
Attachment #8376129 -
Flags: review?(alive)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8376129 [details] [review] patch r+ with nits
Attachment #8376129 -
Flags: review?(alive) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Landed on Gaia/master : f5de3036859c58eed929e3d488ef0c594176a5b2 Thanks all :)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•10 years ago
|
||
It seems weird that Travis would pass because there is one missing test ! Will add it back later !
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•10 years ago
|
||
I added a few minor nits in the PR: https://github.com/mozilla-b2g/gaia/pull/16287/ Thanks for doing this!
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #7) > I added a few minor nits in the PR: > https://github.com/mozilla-b2g/gaia/pull/16287/ Thanks for doing this! Thanks Kevin ! Just updated it
Assignee | ||
Comment 9•10 years ago
|
||
Thanks all, just re-landed on Gaia/master : e35a9d432eb2cbe57c47dbd635398555fd3682ff
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•