Closed Bug 971565 Opened 9 years ago Closed 9 years ago

[System2] Instantiable Title

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alive, Assigned: eragonj)

References

Details

Attachments

(1 file)

We need title.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
Just want to know more about System and took this easy one as a good start :P
Assignee: nobody → ejchen
Comment on attachment 8376129 [details] [review]
patch

Hi Alive, 

can you help me review this part when you have time :) ?

This change just got green from Travis (https://travis-ci.org/mozilla-b2g/gaia/builds/19012997)

Big thanks !!
Attachment #8376129 - Flags: review?(alive)
Comment on attachment 8376129 [details] [review]
patch

r+ with nits
Attachment #8376129 - Flags: review?(alive) → review+
Landed on Gaia/master : f5de3036859c58eed929e3d488ef0c594176a5b2

Thanks all :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
It seems weird that Travis would pass because there is one missing test ! Will add it back later !
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I added a few minor nits in the PR: https://github.com/mozilla-b2g/gaia/pull/16287/ Thanks for doing this!
(In reply to Kevin Grandon :kgrandon from comment #7)
> I added a few minor nits in the PR:
> https://github.com/mozilla-b2g/gaia/pull/16287/ Thanks for doing this!

Thanks Kevin ! Just updated it
Thanks all, just re-landed on Gaia/master : e35a9d432eb2cbe57c47dbd635398555fd3682ff
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.