971565 - [System2] Instantiable Title

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need title.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Just want to know more about System and took this easy one as a good start :P

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8376129 [details] [review]
patch

Hi Alive, 

can you help me review this part when you have time :) ?

This change just got green from Travis (https://travis-ci.org/mozilla-b2g/gaia/builds/19012997)

Big thanks !!

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8376129 [details] [review]
patch

r+ with nits

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Landed on Gaia/master : f5de3036859c58eed929e3d488ef0c594176a5b2

Thanks all :)

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

It seems weird that Travis would pass because there is one missing test ! Will add it back later !

Comment 7

[Kevin Grandon :kgrandon]

I added a few minor nits in the PR: https://github.com/mozilla-b2g/gaia/pull/16287/ Thanks for doing this!

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Kevin Grandon :kgrandon from comment #7)
> I added a few minor nits in the PR:
> https://github.com/mozilla-b2g/gaia/pull/16287/ Thanks for doing this!

Thanks Kevin ! Just updated it

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, just re-landed on Gaia/master : e35a9d432eb2cbe57c47dbd635398555fd3682ff