971583 - (SQLite3.8.3.1) Upgrade to SQLite 3.8.3.1

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Boaz Dodin]

http://www.sqlite.org/news.html

SQLite version 3.8.3.1 fixes a bug present in versions 3.8.1, 3.8.2 and 3.8.3 that can cause queries to omit valid out rows. Upgrading from those versions is recommended.

The problem only comes up if SQLite is compiled with either the SQLITE_ENABLE_STAT3 or SQLITE_ENABLE_STAT4 compile-time options. In that case, if a query has a WHERE clause that contains expressions like this:

    WHERE (expr1 OR expr2 OR ... OR exprN) AND column IS NOT NULL 

Where all of expr1 through exprN are suitable for use by indexes, then during query planning SQLite might mistakenly converted the "column IS NOT NULL" term into "column>NULL". But the latter term is never true, and so the query would return no rows.

* Fix a bug (ticket 4c86b126f2) that causes rows to go missing on some queries with OR clauses and IS NOT NULL operators in the WHERE clause, when the SQLITE_ENABLE_STAT3 or SQLITE_ENABLE_STAT4 compile-time options are used.
* Fix a harmless compiler warning that was causing problems for VS2013.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I don't think the bug is going to affect us, though, since we just upgraded to 3.8.3, there's no reason to not take this.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

But it sounds like upgrading aurora (3.8.2) or beta (3.8.1) isn't worth it.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.8.3.1 - Mozilla changes

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8374979 [details] [diff] [review]
Upgrade to SQLite 3.8.3.1 - Mozilla changes

Review of attachment 8374979 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think it's worth to uplift, while it's a recommended upgrade, the cases where the bug exist are quite rare (or nonexistent) for us.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/622a249a2d72
https://hg.mozilla.org/integration/mozilla-inbound/rev/a802f84d9c94

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/622a249a2d72
https://hg.mozilla.org/mozilla-central/rev/a802f84d9c94