Closed Bug 971626 Opened 7 years ago Closed 7 years ago
Restore Defaults should collapse Title Bar
+++ This bug was initially created as a clone of Bug #966599 +++ Follow-up to bug 966599. Just like for non-default toolbars, clicking 'Restore Defaults' should also reset the Title Bar option and collapse it, since not showing it is the default state.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8376023 - Flags: review?(gijskruitbosch+bugs)
Whiteboard: [Australis:P?] → [Australis:P3]
Comment on attachment 8376023 [details] [diff] [review] Patch Review of attachment 8376023 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! ::: browser/components/customizableui/test/browser_970511_undo_restore_default.js @@ +82,5 @@ > + ok(restoreDefaultsButton.disabled, "Restore defaults button should be disabled after reset"); > + is(titleBarButton.hasAttribute("checked"), !defaultValue, "Title bar button should reflect default value after reset"); > + is(Services.prefs.getBoolPref(prefName), defaultValue, "Reset should reset drawInTitlebar"); > + ok(CustomizableUI.inDefaultState, "In default state after titlebar reset"); > + Nit: check that the undo button is shown and enabled.
Attachment #8376023 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed a follow-up to fix a CSS reference that didn't get caught when I updated the ID for the undo-reset-button. https://hg.mozilla.org/integration/fx-team/rev/cc2833ffc0c5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Jared, was there a reason not to request aurora approval on this bug (yet) ?
No reason, just been behind with travel and setting up a new machine.
[Approval Request Comment] Bug caused by (feature/regressing bug #): adding more functionality to restore defaults User impact if declined: restore defaults doesn't undo titlebar changes Testing completed (on m-c, etc.): on m-c for a while now Risk to taking this patch (and alternatives if risky): none String or IDL/UUID changes made by this patch: none
Attachment #8381673 - Flags: approval-mozilla-aurora?
Attachment #8381673 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Mac OS X 10.9, Windows 7 64bit and Ubuntu 12.04 using: - latest Aurora 29.0a2 (build ID: 20140314004001) - latest Nightly 30.0a1 (build ID: 20140314030202)
You need to log in before you can comment on or make changes to this bug.