Closed
Bug 971646
Opened 10 years ago
Closed 10 years ago
FileUtilsWin.h fails to compile on GCC.
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
9.39 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
It's mostly due to char16_t/wchar_t mismatch. Other than trivial chanches, it revealed some missing bits in nsStringAPI.h variant of nsString because the header is also used in test code, which doesn't use internal nsString.h. It's also a reason why I added a few reinterpret_casts. wwc() is only present in nsString.h and I'm not sure we want to include that in nsStringAPI.h. If you think that would be better, I will change the patch.
Attachment #8374718 -
Flags: review?(benjamin)
|
||
Updated•10 years ago
|
Attachment #8374718 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0208aa0c7dc1
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0208aa0c7dc1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•